glepur/react-native-swipe-gestures

Scroll view scrolling not working in side the <GestureRecognizer>

Anunest opened this issue · 4 comments

Anunest commented
Scroll view scrolling not working in side the
amartyach98 commented

Hi @Anunest have you got any solution for this issue?

MerijnCanvas commented

@amartyach98 If you still want this fixed, you could try and install my forked repo via npm install MerijnCanvas/react-native-swipe-gestures

  • 👍3
Joseph-D-Bradshaw commented

I have got mine working inside of a ScrollView just fine, anything in particular that caused your issue?

johnslobodan07 commented

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-swipe-gestures/index.js b/node_modules/react-native-swipe-gestures/index.js
index 38d1db5..fd94b51 100644
--- a/node_modules/react-native-swipe-gestures/index.js
+++ b/node_modules/react-native-swipe-gestures/index.js
@@ -58,8 +58,8 @@ class GestureRecognizer extends Component {
 
   _gestureIsClick(gestureState) {
     return (
-      Math.abs(gestureState.dx) < swipeConfig.gestureIsClickThreshold &&
-      Math.abs(gestureState.dy) < swipeConfig.gestureIsClickThreshold
+      Math.abs(gestureState.dx) < swipeConfig.gestureIsClickThreshold 
+      //&& Math.abs(gestureState.dy) < swipeConfig.gestureIsClickThreshold
     );
   }
  • 👍2