gleu/sqlite_fdw

Doesn't build against 9.6

Closed this issue · 3 comments

darkixion commented

Getting the following build output:

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -fpic -I. -I./ -I/home/thom/Development/psql/include/postgresql/server -I/home/thom/Development/psql/include/postgresql/internal -D_GNU_SOURCE -I/usr/include/libxml2   -c -o src/sqlite_fdw.o src/sqlite_fdw.c -MMD -MP -MF .deps/sqlite_fdw.Po
src/sqlite_fdw.c: In function ‘sqliteGetForeignPlan’:
src/sqlite_fdw.c:516:8: error: too few arguments to function ‘make_foreignscan’
        NIL);  /* no private state either */
        ^
In file included from src/sqlite_fdw.c:23:0:
/home/thom/Development/psql/include/postgresql/server/optimizer/planmain.h:46:21: note: declared here
 extern ForeignScan *make_foreignscan(List *qptlist, List *qpqual,
                     ^
src/sqlite_fdw.c:518:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make: *** [src/sqlite_fdw.o] Error 1
herisanu commented

Doesn't compile vs. 9.5 also. Any updates on this?

gleu commented

It's now fixed. (yeah, I know, it took me a long time to fix it, sorry about this)