glhd/laravel-addressing

Declaration of Galahad\LaravelAddressing\Collection\CountryCollection::pop()

Closed this issue · 4 comments

Hello,

I'm getting this after updating to latest Laravel:

Declaration of Galahad\LaravelAddressing\Collection\CountryCollection::pop(): ?Galahad\LaravelAddressing\Entity\Country must be compatible with Illuminate\Support\Collection::pop($count = 1)

Here's the pull request and changelog:
laravel/framework#38093
https://github.com/laravel/framework/blob/8.x/CHANGELOG-8.x.md#added

Would it be possible to patch the pop and shift methods? Thank you!

This will be addressed in version 3.0.0 (which mostly just drops support for older Laravel and PHP versions—no other major changes).

Cool! When is v3 released? Thank you!

It's out now :)

Sweet, thank you! Worked like a charm!