glideapps/quicktype

[BUG]: QuickType 23.1.0 ignores language-specific command line arguments

Closed this issue · 2 comments

daviduzumeri commented

When I use QuickType 23.0.0, language-specific CLI arguments (like struct-or-class for Swift) work properly. In 23.1.0, they don't appear to be parsing at all -- it'll always return a struct. Same goes for C# arguments.

Issue Type

Parameter parsing

Context (Environment, Version, Language)

Input Format: JSON Schema
Output Language: Swift, C#

CLI, npm, or app.quicktype.io: CLI
Version: 23.1.0

Description

Input Data

This happens with any input data.

Expected Behaviour / Output

I'd expect the output to match the CLI arguments specified.

Current Behaviour / Output

It ignores any language-specific CLI arguments.

Steps to Reproduce

  1. Install QuickType at 23.1.0
  2. pnpm quicktype --src "APIVariables.json" --src-lang schema --lang swift --struct-or-class class -o "Models.swift"
  3. Output contains a struct, not a class
  4. Pin dependency to 23.0.0
  5. pnpm quicktype --src "APIVariables.json" --src-lang schema --lang swift --struct-or-class class -o "Models.swift"
  6. Output now contains a class.
lovelyPuppies commented

Same problem with C++ output. --no-boost, and --code-format have no effect in v23.1.1.

srad commented

Yeah same problem with C#, how can such an obvious test case fall through?

  • 👍1