Build is circumventing type checking
Opened this issue · 0 comments
asakusuma commented
If you turn on noImplicitAny
in tsconfig
, you get a bunch of error TS7016: Could not find a declaration file for module...
errors. Turns out, the typings
references in a bunch of the glimmer packages are broken (fix pr). If you fix the typings references, then you get a bunch of type errors.
A sample typescript error:
ERROR in /Users/akusuma/workspace/opensource/hello-glimmer/node_modules/@glimmer/component/dist/types/component-manager.d.ts
(7,22): error TS2420: Class 'ComponentManager' incorrectly implements interface 'ComponentManager<Component>'.
Types of property 'prepareArgs' are incompatible.
Type '(definition: ComponentDefinition, args: EvaluatedArgs) => EvaluatedArgs' is not assignable to type '(definition: ComponentDefinition<Component>, args: EvaluatedArgs, dynamicScope: DynamicScope) => ...'.
Types of parameters 'definition' and 'definition' are incompatible.
Type 'ComponentDefinition<Component>' is not assignable to type 'ComponentDefinition'.
Types of property 'manager' are incompatible.
Type 'ComponentManager<Component>' is not assignable to type 'ComponentManager'.
Property 'env' is missing in type 'ComponentManager<Component>'.