glimmerjs/glimmer-vm

Expose `voidMap` and `visitorKeys`

Closed this issue a year ago · 4 comments

fisker commented a year ago

Prettier is using them

https://github.com/prettier/prettier/blob/e682577c08e83c0ab272fc73ad1633883ad5d1a5/src/language-handlebars/visitor-keys.evaluate.js#L1
https://github.com/prettier/prettier/blob/e682577c08e83c0ab272fc73ad1633883ad5d1a5/src/language-handlebars/html-void-elements.evaluate.js#L1

These sub paths are removed in v0.85, can we export them?

NullVoxPopuli commented a year ago

looks like they may still be available from @glimmer/syntax, just here:

https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAKjgQwM51TArgMx3HKCEOAcgAEBzAG1BAFMoB6VATwDsZkAPUgbgBQAzLhwA6AIIBlACoA3AIxi5wVMBjQA0vVaogA

but according to https://www.npmjs.com/package/@glimmer/syntax?activeTab=code
it's not exported.

thanks for reporting!

fisker commented a year ago

Thanks for the quick fix, we also need voidMap.

fisker commented a year ago

Or an array of void element tags, even better.

NullVoxPopuli commented a year ago

you're right! added. thanks!