glimmerjs/glimmer-vm

Let's land the ErrorRecovery work

Opened this issue · 0 comments

Steps:

  • baseline bench in js-framework-benchmark
    • needs to be updated to latest ember-source, as the VM has been upgraded
  • link #1501 to ember-source (NOTE: additional followups here: #1528)
    pnpm link:all in glimmer-vm and pnpm link:glimmer-vm in ember-source

Results:

Left to right:

  • ember-source 5.7 (canary)
  • ember-source 5.7 (canary + glimmer-vm's main branch)
  • ember-source 5.7 (canary + glimmer-vm's error-recovery branch)

image

image

2323-12-12

ember-source is the same between both runs, (main)
only difference is glimmer-vm published vs main
still feels like margin of error though.
would need to compare with other folks' machines.

image

2023-12-11

NOTE: I need to use the same ember-source for both of these to reduce variables.
This bench had two variables:

  • super old glimmer-vm vs glimmer-vm @ main
  • ember-source 5.3 vs 5.6
  • the current glimmer-vm on ember-source is much newer

ember-source 5.3 with glimmer-vm 0.84.2
vs
ember-source 5.6-alpha with glimmer-vm @ main

image