glotzerlab/rowan

Angle computed by geometry inconsistent with documentation

malramsay64 opened this issue · 1 comments

The documentation states that the rowan.geometry.angle function is identical to rowan.geometry.intrinsic_distance(p, np.array([1, 0, 0, 0])). However this is not the case for a simple example

>>> rowan.geometry.angle([0, 0, 0, 1])
3.141592653589793
>>> rowan.geometry.intrinsic_distance([0, 0, 0, 1], [1, 0, 0, 0])
1.5707963267948966

This is probably a result of the changes in c563e82 (ref #4) which don't update the documentation for the angle function.

vyasr commented

You're right, thanks for the find!