glotzerlab/signac

Block merging with incomplete PR check list

cbkerr opened this issue · 4 comments

Feature description

After streamlining the PR template to include a checklist that must be completed (#686), I think having an automatic check would be a helpful reminder to reviewers. Would it be too heavy handed?

However, there is no way yet to have github automatically block merging with an incomplete "task list". (https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists)

Proposed solution

With some quick searching this seems like an option: https://github.com/stilliard/github-task-list-completed.
Note the external privacy policy: https://blog.stapps.io/privacy/#appssuchastasklistcompleted

vyasr commented

A different but somewhat related request: it would be nice if labeling a PR as "blocked" would actually prevent merging until that label is removed to avoid accidental merges.

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

vyasr commented

@cbkerr are you still interested in adding this to signac (and maybe porting it to other repos as well if it works well here)?

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.