gmariani/minerva

The output is wrong.

Closed this issue · 4 comments

Thank you for fixing #53.
It can open the sol file with a special tag now. But when editing this kind of 
file, the output was wrong.

See below:
I want to change the "gold" object in 00000001_original.sol from 500 to 999.
When I use winhex, the output file (00000001_winhex.sol) can be recognized by 
the flash program.
But using minerva 4.1, the output (00000001_minerva.sol) can't be recognized.

I think the problem may be that the sequence or offset of the objects storing 
in the sol file is changed.

Able to fix it?

Original issue reported on code.google.com by qq169312...@gmail.com on 9 Jan 2015 at 3:03

Can you attach the files you edited please?

Original comment by gmariani405 on 10 Jan 2015 at 3:02

  • Changed state: Accepted
  • Added labels: ****
  • Removed labels: ****
I attached the files, but may be missing.
So attached again.

Original comment by qq169312...@gmail.com on 10 Jan 2015 at 12:09

  • Added labels: ****
  • Removed labels: ****

Attachments:

It was an error in how it calculate the length of UTF-8 strings. Since your 
file path has chinese it was way off. I have a new version coming soon, i also 
added a toggle for the sidebar sort in the about window. Disabling the sort 
will keep the original data order of the file. So when you edit with minerva, 
the only difference between that and the original file will be your change, 
much like what you do with winhex.

Original comment by gmariani405 on 10 Jan 2015 at 2:54

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****
It works, thanks.

Original comment by qq169312...@gmail.com on 12 Jan 2015 at 2:32

  • Added labels: ****
  • Removed labels: ****