gmathi/NovelLibrary

[bug] chapter position is not remembered, if chapter was downloaded

Hulkmaster opened this issue · 13 comments

Debug-info:
App Version: 0.15.2.beta_89
OS Version: 3.18.137-g72a7a64494e(5972272)
OS API Level: 29(REL)
Manufacturer: Google
Device: sailfish
Model (and Product): Pixel (sailfish)
Display: 1080x1794

If I have chapter downloaded, when I resume to reading, often position resets to start

Expected: last position should be remembered

This is an actual bug I've noticed as well

Roger that! Will test and fix it.

Update: I tested this a random novel I downloaded. Seems to be working fine.
@Hulkmaster Would you be able to tell me the novel and the chapter you encountered this on?

one sec, will try to find 100% repro

So repro is as easy as

Sharing URL
https://www.novelupdates.com/extnu/489305/

  1. download chapter

  2. open it and scroll to any point

  3. press back button

  4. open chapter again

  5. (expected) - return to saved point

  6. (happened) - chapter started from beginning

Hmm... Very weird!! I wasn't able to reproduce this on the simulator. I will try to match the settings you showed and fire up the simulator.

20200911_232659.zip
video with repro

I have to mention that we do have the same device, pixel 4 XL.

On Fri., Sep. 11, 2020, 14:44 Govardhan Naidu Mathi, < @.***> wrote: Hmm... Very weird!! I wasn't able to reproduce this on the simulator. I will try to match the settings you showed and fire up the simulator. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#120 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCR2W4OR3J6DVIVAQ5F2WDSFJVZJANCNFSM4QU3PPTQ .

Wait no nvm, its just the same pixel line not the same device

@gmathi Fixed in new commit.

Released in 0.15.5