gnewton/jargo

code may not handle CR newlines correctly

Opened this issue · 1 comments

brown commented

Your code uses reader.ReadLine() to break a jar manifest into separate lines. When I looked at the code for that function, it did not appear to treat lone CR (carriage return) characters as line terminators. The spec for jar file manifests says that a newline is denoted by CR NL, NL alone, or CR alone.

Here is a link to the spec: https://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html#Manifest_Specification

I will look in to this. I may try to create a jar file which causes things to break due to this issue.
Thanks! :-)