gnoff/react-tunnel

shouldComponentUpdate issue

Closed this issue · 1 comments

rt2zz commented

My injected component was not rerendering. I believe based on cursory review that inject should be using shallowEqualScalar on both provided and props (instead of shallow equal on just provided)

gnoff commented

updated to shallowEqual compare props. also changed provided compare to use nextState rather than nextContext since this is the mapped version of provided.

69e7270

closing