go-fed/apcore

Improvements to example install + CLI

aschrijver opened this issue · 4 comments

Based on my apcore installation experience I created a list of CLI improvements to PR:

  • Improve Moo text balloon
  • Add space after each CLI question (update: known bug manifoldco/promptui#116)
  • Add URL of installation tutorial to output (not doing: needs site / docs update)
  • Rename the generated binary to gofed-apcore-example (not doing, use command line or build script)
  • Fix repeating prompt Label (not doing: known bug, unfixed manifoldco/promptui#122)
  • Retain the Label after choosing from a Select prompt
  • Fix bell sound on backspace + cursor movement (update: known bug manifoldco/promptui#49)
    • Needs update of promptui from v0.3.2 to v0.8.0
    • Needs fix of race condition introduced after v0.4.0 (PR issued: manifoldco/promptui#169)

Pending the last item, I keep the changes in local cli-improvements branch for now.

Thank you so much for creating this list and digging into the technical issues you found. I'll keep this open until the last item can also be addressed.

Also, do you have a merge/pull request for the items you were able to address? Let me know if you'd like to work to get it into the mainline.

I also want to include another checkbox you mentioned in #56:

  • Present default values in UI prompts
  1. Presenting defaults

Instead of showing the default values after the colon, suggesting to have them before that between brackets. After the colon there's no text and an override value can be immediately typed.

Enter the postgres database port [5432]: █

Also, do you have a merge/pull request for the items you were able to address? Let me know if you'd like to work to get it into the mainline.

I have to see.. it is some time ago (and I have bad memory, probably due to info overload and continual distraction). Also, when I finally get to do deep work again, intend to build off activity, so I hope I don't forget.