go-git/go-billy

osfs doesn't seem to be referencing the underlying chroot

jawr opened this issue · 2 comments

jawr commented

I haven't dug too deep/tested this yet, but it seems to me that in a lot of instances methods are referencing the stdlib os rather than fs for operations, i.e. https://github.com/go-git/go-billy/blob/master/osfs/os.go#L45 there is no reference to the chroot

Please feel free to ignore this if I'm being a wally.

smola commented

@jawr What are you trying to accomplish? The chroot subpackage in go-billy works on top of another go-billy filesystem, not the other way around. When you use osfs.New(basedir), the osfs filesystem is wrapped with a chroot to make sure that all operations are relative to basedir.

jawr commented

Closing issue, as I was being a wally!