Commits and pull files

Question

Commits and pull files

lunny opened this issue 8 years ago · 33 comments

Before we can start a review, we can implement comment on one line of PRs at first.
I think this includes two sub issues.

~~Commit comment #3748~~ see #4898
Pull files comment #3748

Answer 1 · 2016-11-09T18:28:47.000Z

well, If we implement comments on commits we should get this "for free" 🙂

Answer 2 · 2016-11-09T18:38:00.000Z

I'm not sure. I don't know the internals, but the comment may go onto a commit page. Then you can discuss this commit.
But this issue targets a bigger picture. A PR might have multiple commits and those can change over time. So I agree that comments on commits might benefit comments on PR with some work already done nevertheless I feel that there's more to it.

Answer 3 · 2016-11-10T01:00:30.000Z

Yes, comment on commits.

Answer 4 · 2016-12-06T18:49:20.000Z

I can probably make a proof of concept for this sometime during the weekend or next week

Answer 5 · 2017-01-26T15:01:41.000Z

@bkcsoft any update?

Answer 6 · 2017-01-26T16:49:54.000Z

Aren't we going to do this with git-appraise ? See #733

Answer 7 · 2017-01-26T18:40:17.000Z

I can look at this, but this will be not so fast

Answer 8 · 2017-02-14T02:13:11.000Z

Move this v1.2 since #733 has moved.

Answer 9 · 2017-02-14T02:17:08.000Z

I have tried to do something. Comments on PR is not the same as comments on commits. These are two similar PRs. For comments on PR, all the comments should be indexed by the IssueID, treePath, lineNum and actionType(add line or del line). But for comments on commits, all the comments should be indexed by commitSHA, treePath, lineNum and actionType(add line or del line).

Answer 10 · 2017-09-12T08:18:22.000Z

I send the draft as seen to comment on the code.
For some time I will show demo work.

Answer 11 · 2017-09-22T10:02:48.000Z

Hello.
I send you a preview of the model of action.
This is a static implementation - proof of concept

gitea_comment_code.zip

Answer 12 · 2017-09-22T10:07:12.000Z

@qdbdbp Looks great but I think a button to cancel the comment is missing. How does it look in unified mode?

Answer 13 · 2017-09-22T13:08:13.000Z

gitea_c_o_c.zip

I send updated versions.
I'm waiting for comments on this.

Answer 14 · 2017-09-22T13:10:19.000Z

@qdbdbp I am working on a branch about this, I will send a PR today or last two days. I will copy your code to that PR.

Answer 15 · 2017-09-22T14:23:29.000Z

@qdbdbp It seems only the first comment on the code line. how to show the second or third comment on the same line?

Answer 16 · 2017-09-23T06:05:17.000Z

@qdbdbp I have sent a PR #2583 but I think maybe I have lost something from your zip. Please review the code and help me with the UI.

Answer 17 · 2017-09-25T06:41:31.000Z

no problem. I will do what I need
I'll take your code and I'm already working on the correct code.

Answer 18 · 2017-09-25T10:28:44.000Z

@qdbdbp, what tool do you use to do those designs? 😅

Answer 19 · 2017-09-25T12:51:10.000Z

hi. I use it for quick drafts this tool:

https://mockflow.com/

Answer 20 · 2018-03-13T14:37:31.000Z

I don't mind to pay to have this feature... how much? who?

Answer 21 · 2018-03-13T14:39:34.000Z

@bclermont we already have a wip pull request #2583.

Answer 22 · 2018-03-13T14:41:06.000Z

@lunny yeah, but it can't be merged, and haven't been updated in 6 months! I want to help to implement this feature

Answer 23 · 2018-03-13T15:05:45.000Z

You could use https://www.bountysource.com/teams/go-gitea

Answer 24 · 2018-03-14T01:19:30.000Z

@lunny thanks for posting that link. I added to the bounty.

Answer 25 · 2018-03-28T23:37:12.000Z

Thanks for the bounty link. I added $100 if this can be resolved within 6 months. This is the basically the only feature that I still miss after migrating from Github to Gitea. I will be super duper happy when Gitea supports in-line code reviewing for pull requests. Go Gitea team!

Answer 26 · 2018-03-29T02:05:24.000Z

I will give equivalent of 100$ in a crypto currency to whoever earn the bounty

Answer 27 · 2018-05-04T03:44:33.000Z

Are there things to follow?

Answer 28 · 2018-05-04T04:03:09.000Z

Please follow #3748

Answer 29 · 2018-09-06T22:56:08.000Z

Is comment in commits implemented? If it isn't implemented I think this should be reopen

Answer 30 · 2018-09-07T01:17:00.000Z

@xxxTonixxx right, Only pull request comment was implemented by #3748 . @lafriks @JonasFranzDEV

Answer 31 · 2018-09-07T01:17:18.000Z

But we could open another issue to keep this one closed.

Answer 32 · 2018-09-07T06:29:23.000Z

👍, I will do it

Answer 33 · 2018-09-11T06:07:51.000Z

@xxxTonixxx Thank you!