Reference issue from pull request
svarlamov opened this issue · 13 comments
- Gitea version (or commit ref): 7ec6cdd
Description
When referencing an issue from a pull request description, ie., targeting #125 links properly, but when you're in the issue, there's no message saying that it was referenced in a pull request (such as Gitea does with commit messages or the way that Github does with pull request descriptions)
Also, referencing an issue, ie., see #125 from an issue, links, but when you're in the referenced issue, there's no message about the reference -- as you would have in Github for instance
Can you create sample on try.gitea.io to demonstrate this problem
@lafriks - sure!
Issue to issue ref:
1: https://try.gitea.io/svarlamov/sample-issues-3134/issues/1
2: https://try.gitea.io/svarlamov/sample-issues-3134/issues/2
2 references 1, but there's nothing in 1 to show that (as there would be for a commit msg)
PR to issue ref:
PR(a): https://try.gitea.io/svarlamov/sample-issues-3134/pulls/3
ISSUE(b): https://try.gitea.io/svarlamov/sample-issues-3134/issues/1
PR(a) references ISSUE(b), however, there's nothing to indicate that in ISSUE(b) -- as there otherwise would be for a commit msg
I think @svarlamov means reference comments.
i think he means an information like the fourth under this comment in a pull request here.
and like the one below that. :-)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
@lunny Perhaps the stale bot should be configured to ignore issues that are tracked in a milestone, or another tag could be created to exempt an issue from auto-closing.
It's not exactly ideal to keep bumping them manually.
there is already label reviewed/confirmed that stalebot won't touch :)
+1 for linking back to the PR from the issue view.
But also, it'd be nice to be able to close issues from PR descriptions. I.e. if the reference is "closes #123" it would close issue number 123 once the PR is merged (same as from commits). I do this all the time on GitHub and kind of miss it on Gitea now.
This is pending. I'm interested in this feature, I might work on it next. Any caveats I should be aware of?
@skddc One thing at a time ;-) make a new issue on that one (It's probably somewhere already!) please
@guillep2k Thanks!