Integrate GitHub approval
tboerger opened this issue · 14 comments
We should really implement the approval process of GitHub so that we are just enforcing the number of approvals.
In fact, we can count the lgtm on LGTM comments + Github approvals. Not only LGTM comments.
But counting only approvals should be the safest thing, same for change requests.
Could we then drop LGTM completely ?
In that case we don't need lgtm comments, only approve clicks
Sounds better to me, unless we plan to move out of github soon and thus want to have an alternative
count the people number who approvals and lgtms.
But sometimes, ad slight change, it's only lgtm what you can do. So that, I think plus the two is all right.
keeping both is fine by me
I would prefer the approval process only. Other remote drivers are anyway not implemented yet. For gitea we can do something similar when we add an approval process. Or we directly integrate that into gitea to avoid the usage of an external service for that.
for simple change for example a typo pr. Lgtm is the only Requirement
for simple change for example a typo pr. Lgtm is the only Requirement
I don;t understand what you mean. We should approve EVERYTHING or nothing :)
I mean if a PR only have changes of typo. how should we approve on github?
The same way as for big changes. Instead of writing LGTM comments you just click the approve button of github.