go-gitea/lgtm

Support for gogs/gitea

tonivj5 opened this issue · 14 comments

tonivj5 commented

lgtmco/lgtm#55

Thanks for maintaining this project! 😄

Caballerog commented

any news?

lunny commented

I think Gitea will integrated it internal not a separated service.

  • 👍2
Caballerog commented

That's a great new :-)

bkcsoft commented

@lunny I would much rather see it as a separate service though. Unless we get "Approvals" integrated into CodeReview :)

  • 👍2
lunny commented

@bkcsoft Yes, I mean that.

  • 👍1
lafriks commented

I'm thinking on creating approval system like in GitLab but without code review and approvals stored in database in coming weeks

lafriks commented

@bkcsoft why don't you like integrated?

lunny commented

@lafriks I like the github's approvals but I think it's need an approvals number on repository settings.

lafriks commented

Yes, that's what I'm also plan to add. When I have something to show I will create wip PR

  • 👍2
  • ❤️2
bkcsoft commented

@lafriks External integration is fine, internal integration is not very KISS 😉

lafriks commented

Yes but internal can do a lot more and will be more reliable

lunny commented

@bkcsoft I don't think so.
For Gitea's users, KISS means don't let me change this site to other site. Both internal or external integrations are OK.
For Gitea's manager, KISS means less maintain things(one binary/one service) since current Gitea's objective is for small teams or organizations.
Maybe it could be integrated into Gitea as well as run as a seperated service. 😄

lafriks commented

I agree with @lunny that it can be both internal or external but in both cases in gitea there should be some kind of infrastructure to store approval count/info and limit PR merging before approval conditions are met

  • 👍2
6543 commented

gitea has it build in ...