go-graphite/graphite-clickhouse

bufio.Scanner

ralphM78 opened this issue · 3 comments

ralphM78 commented

Hi,

as I mentioned in #67 (comment) would it be possible to make bufio.Scanner a config option and print out a clear log message if the size is too small ? I have increased the size again to look backwards more than 75 days.
@ihard where have you seen this error message ? I haven't seen it. Have to find out the hard way.
No idea what the right fixed size could be. Maybe someone would like to look backwards some years.
So make it a config option would be nice if it's possible. I'm really not a developer so I can't do it by myself
.
Ralph

Felixoid commented

Hey @ralphM78, could you, please, try the #93? BTW, to get rid of the issue with 100% sure you should enable internal-aggregation, see #88

upd: I guess, 64MiB is a reasonable limit, since if you have that amount of points, you'll, most probably, get the OOM somewhere in any case :-j

ralphM78 commented

Hi,

I have tried it and it looks good so far. Now I will have a look at internal-aggregation.
Thanks to you

Felixoid commented

I assume it's done with #93