go-mail/mail

Suggest NetDialTimeout be part of Dialer NOT Global

krolaw opened this issue · 2 comments

For systems like Google's app engine (standard), out going sockets need a context (per incoming http connection). see: https://godoc.org/google.golang.org/appengine/socket
This makes it really hard when the netDialout command is global, since simultaneous requests are coming in. It's much more practical than before though.

ivy commented

@krolaw Agreed. I would accept a pull request adding a NetDialTimeout field to Dialer and using the global NetDialTimeout as a fallback.

Edit: I see you've already done this in PR #41. I'll review and see if we can get this merged. 😄

Hi, any movement on this? Thanks.