go-openapi/jsonreference

purell module is no longer maintained

gkarthiks opened this issue · 3 comments

gkarthiks commented

This is a proactive issue opened to bring to the maintainers' knowledge about the maintenance status of the purell package.

The purell package used in the jsonreference package is not maintained anymore and looking for maintainers.

jsonreference/reference.go

Line 117 in 28a8ff9

r.referenceURL, _ = url.Parse(purell.NormalizeURL(parsed, purell.FlagsSafe|purell.FlagRemoveDuplicateSlashes))

We at kubernetes/kubernetes#103801 project moved the logic inside our code base and removed the direct dependency.

So we are hoping that the jsonreference will also consider in-sourcing that code logic.

References:

purell issue: PuerkitoBio/purell#33
Kubernetes Issue: kubernetes/kubernetes#103068

Note: Happy to create a PR, please let me know the path forward.

gkarthiks commented

Apologies for the ping. But @casualjim @gbjk @honza @frapposelli can any one of you please provide your opinion?

erraggy commented

Judging by the purell implementation, all that's needed to be applied are:
FlagLowercaseHost
FlagLowercaseScheme
FlagRemoveDefaultPort
FlagRemoveDuplicateSlashes

Since the url.Parse takes care of all the others defined in FlagsSafe.

I'll give this a shot and submit a PR.

  • 🚀1
erraggy commented

So there's the PR to remove it. Happy to make any changes maintainers would like.

  • 🎉1