Exit Code 0 even if Hooks plugin failed
AndreasSko opened this issue ยท 2 comments
While developing a custom Hooks plugin I noticed that semantic-release will exit successfully, even if the Hooks plugin returned an error. I'm wondering if this is expected behavior or a bug. I think
semantic-release/cmd/semantic-release/main.go
Lines 308 to 321 in 18e8bae
is missing an
exitIfError
, which is the case for other plugin calls (like Init).
I'm happy to open a PR if this is something that is ok to be changed ๐
Hi @AndreasSko, the idea was that hooks plugins should never interrupt the release flow.
But I can see cases where this makes sense. We can put it behind a cli flag, so users have to explicitly enable it.
Update: I was also just working with a hooks plugin and if the success hook fails, semantic-release should definitely return a non-zero exit code. Thanks for raising this issue, it should be fixed with the next release. ๐
Thank you, @christophwitzko! Really appreciate it ๐