goadesign/clue

Documentation for clue/metrics is outdated

williammoran opened this issue · 3 comments

williammoran commented

https://github.com/goadesign/clue/blob/main/metrics/README.md
Specifies mux.Handle("GET", "/metrics", metrics.Handler()) which doesn't work with the current version.
There may be other errors within the README, I haven't had an opportunity to review the entire thing.

raphael commented

Nice catch! do you think you could write a PR to fix the docs? Thank you!

williammoran commented

Is mux.Handle("GET", "/metrics", metrics.Handler(ctx).ServeHTTP) the appropriate fix?

raphael commented

Yes, perfect!