gocario/PHBank

Therian Forms of Tornadus, Thundurus, and Landorus not displaying correctly

d4mation opened this issue · 6 comments

Using b402734 of PHBank and gocario/PKBrew@e20068a.

Landorus shows as a green square, Tornadus and Thundurus show as Female Frillish and Female Jellicent respectively within the Box View.

Full-size Sprite on the top screen doesn't show them as Therian form either.

In this case all three should be in Dream Balls (Obtained via Pokemon Dream Radar), but they are showing as caught in a Park Ball.

image

image

image

Can you try with these modified files from that commit:
gocario/PKBrew@7d69e40
PS: I don't render the form on the top screen icon for the moment, because I don't have the arts.

That does fix the problem with their icons not loading properly in the box view for those forms, but now Female Frillish/Jellicent won't load properly since they've been removed from the spritesheet.

Is there a particular reason that all the Megas are in the spritesheet? Outside of cheating, a Pokemon shouldn't be able to go into the PC as a permanent Mega. Those may be a better candidate for removal if it is a space issue.

Ah, and you're right about the top screen. I didn't notice that no forms were included in that folder within romfs at all.

Can you try again with these two commits:
e368db8
gocario/PKBrew@7bcfe64

There is too much Pokémon forms (excluding non PCable) to be contained in the normal spritesheet, that is why I had to use another one.

Sorry, I've been away from my computer that has CTRULIB and such set up for a couple days.

Using the latest commits of both PHBank and PKBrew:

3DSX: Crashes after game selection.

Problem happened: 0x84
* Save
* Filesystem
PHBank version: 020001b0

CIA: Still shows the male forms for Pyroar, Unfeazant, and Frillish/Jellicent when viewing a Female Pokemon.

Otherwise, the Therian Form issue has been fixed.

I did a new commit, which shall fix the females forms for these 4 species: e23208a
Keep in mind that for CIA build you need to have a __cia defined, and nothing special for the 3DSX
Check that: https://github.com/gocario/PHBank/blob/master/Makefile#L60 -D__cia will define __cia in the compilation, remove it for the 3dsx build.

The CIA build is showing the proper forms for me now. The 3DSX is still crashing with the same error as before and I really have no idea why, but I personally use the CIA anyway. It must just be something funky with my setup since theoretically they should be running the precisely the same code, right?

Regardless, Issue closed! Thanks for looking into this, @gocario!