gocd/gocd-docker

16.5.0 ignores GO_SERVER environment variable

Closed this issue · 19 comments

the agent just connects to 127.0.0.1. works with 16.4.0

Can you provide more details about how you're using it?

Sure sorry, if you run with 16.5.0 or 16.5.0-3305 tag:

docker run -ti -e GO_SERVER=your.go.server.ip_or_host gocd/gocd-agent:16.5.0

the log shows:

./run: line 3: go-common-scripts.sh: No such file or directory
AGNT: ./run: line 8: wait_for_go_server: command not found
AGNT: ./run: line 9: wait_for_msg_time: command not found
AGNT: ./run: line 10: show_msg: command not found
AGNT: [Wed May 25 19:41:42 UTC 2016] using default settings from /etc/default/go-agent

and later

[...] Couldn't access Go Server with base url: http://127.0.0.1:8153/go/[...]

But if you run with the older tag 16.4.0 you don't get those errors and the beginning and later get the expected:

[...] Couldn't access Go Server with base url: http://your.go.server.ip_or_host/go/[...]

Interesting enough with the :latest tag it works too so maybe something went wrong with the tagging of the newest version? I just don't want any "unforseen" updates that's why I specify a major version.

You're right. There is some difference in the images, which a tag (16.5.0) should not have done. I'll try and manually re-tag it to see if it fixes it, but here's what I see.

$ docker images gocd/gocd-agent
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
gocd/gocd-agent     16.5.0              ef77d169ecf4        16 hours ago        676.3 MB
gocd/gocd-agent     16.5.0-3305         ab5705021fe3        16 hours ago        676.3 MB
gocd/gocd-agent     latest              ab5705021fe3        16 hours ago        676.3 MB
gocd/gocd-agent     16.4.0              fc4199118e56        4 weeks ago         571.1 MB
gocd/gocd-agent     16.4.0-3223         fc4199118e56        4 weeks ago         571.1 MB

Notice the change in image ID between 16.5.0 and 16.5.0-3305.

Also, diffing the images:

docker save gocd/gocd-agent:16.5.0-3305 | tar tv >16.5.0_3305.txt
docker save gocd/gocd-agent:16.5.0 | tar tv >16.5.0.txt
$ diff 16.5.0.txt 16.5.0_3305.txt
64a65
> -rw-r--r-- 0/0            7704 2016-05-25 01:26 ab5705021fe30c400d7893209d3ee47de9ebdb8a564be8edc09d04f8a733db41.json
77d77
< -rw-r--r-- 0/0            6801 2016-05-25 01:26 ef77d169ecf4c4aa1c962514cca94b9e2450fef830a40e143e924194d47575df.json
90,91c90,91
< -rw-r--r-- 0/0            1828 1969-12-31 19:00 manifest.json
< -rw-r--r-- 0/0              98 1969-12-31 19:00 repositories
---
> -rw-r--r-- 0/0            1833 1969-12-31 19:00 manifest.json
> -rw-r--r-- 0/0             103 1969-12-31 19:00 repositories

Sigh. It looks like there's some random image pushed as 16.5.0, which docker hub is not allowing me to remove or overwrite with the right one. Still looking.

Till someone can figure out how to get rid of that image being associated to that tag, I've removed 16.5.0 tags from gocd-server and gocd-agent images. The "latest" and "16.5.0-3305" tags are identical and either one can be used instead of "16.5.0", for now. @an-tex, can you please verify that "16.5.0-3305" works for you?

/cc @zabil

zabil commented

Fixed the tagging bit here ee2fd66

Anything else to fix on this?

Hi @arvindsv ,

neither latest nor 16.5.0-3305 are working for me now:

~ > docker pull gocd/gocd-agent:16.5.0-3305
16.5.0-3305: Pulling from gocd/gocd-agent
[...]
Status: Image is up to date for gocd/gocd-agent:16.5.0-3305
~ > docker run -ti -e GO_SERVER=your.go.server.ip_or_host gocd/gocd-agent:16.5.0-3305
[...]
AGNT: java.lang.Exception: Couldn't access Go Server with base url: http://127.0.0.1:8153/go/admin/agent-launcher.jar: java.net.ConnectException: Connection refused

same output for ":latest"

zabil commented

The variables do get passed

~/p/gocd-docker master> docker run -e GO_SERVER=x.x.x.x -ti gocd/gocd-agent:latest env
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=a36e62f169b8
TERM=xterm
GO_SERVER=x.x.x.x
HOME=/root

But the agent ignores it. @ketan @arvindsv can this change cause it?

https://github.com/gocd/gocd/blob/8626470b5d5eb02dfcd65c931e505f2e26684d0f/installers/agent/release/agent.sh#L146

it was
https://github.com/gocd/gocd/blob/16.4.0/installers/agent/release/agent.sh#L108

zabil commented

Found the culprit

e0c865b

zabil commented

@an-tex can you try with

 docker run -ti -e GO_SERVER=your.go.server.ip_or_host gocd/gocd-agent:latest

again and see if it's still a problem?

Thx works for :latest and :16.5.0-3305 !

@zabil: This is what I see:

$ docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
gocd/gocd-agent     latest              6bf32e4d1697        22 minutes ago      676.3 MB
gocd/gocd-agent     16.5.0              34cc625cad1a        51 minutes ago      676.3 MB
gocd/gocd-agent     16.5.0-3305         34cc625cad1a        51 minutes ago      676.3 MB

I did this:

docker rmi gocd/gocd-agent:16.5.0
docker rmi gocd/gocd-agent:16.5.0-3305
docker rmi gocd/gocd-agent:latest

docker pull gocd/gocd-agent:16.5.0
docker pull gocd/gocd-agent:16.5.0-3305
docker pull gocd/gocd-agent:latest

So, latest and 16.5.0 have different IDs. I think we should fix the pipeline which does the tagging/creating and push from there.

Also, gocd/gocd-server doesn't have 16.5.0 tag. If you try to push it, even there the image ID will be different.

$ diff <(docker save gocd/gocd-agent:latest | tar tv) <(docker save gocd/gocd-agent:16.5.0-3305 | tar tv)
1,91c1,91
< drwxr-xr-x 0/0               0 2016-05-26 07:28 0ed56647fba34317f91f5dbc0c73f84aa82fbee9bb2647d3000e51c5cafe5158/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 0ed56647fba34317f91f5dbc0c73f84aa82fbee9bb2647d3000e51c5cafe5158/VERSION
< -rw-r--r-- 0/0            1289 2016-05-26 07:28 0ed56647fba34317f91f5dbc0c73f84aa82fbee9bb2647d3000e51c5cafe5158/json
< -rw-r--r-- 0/0            1024 2016-05-26 07:28 0ed56647fba34317f91f5dbc0c73f84aa82fbee9bb2647d3000e51c5cafe5158/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 1240f94c0c55cedebd4939bd0570126744a8430717ce56670ed84608f08ab7f2/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 1240f94c0c55cedebd4939bd0570126744a8430717ce56670ed84608f08ab7f2/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 1240f94c0c55cedebd4939bd0570126744a8430717ce56670ed84608f08ab7f2/json
< -rw-r--r-- 0/0            4096 2016-05-26 07:28 1240f94c0c55cedebd4939bd0570126744a8430717ce56670ed84608f08ab7f2/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 236213fa5f45f57f31f0e301901c32793c6402eba8c1164b99e13cf724f704ce/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 236213fa5f45f57f31f0e301901c32793c6402eba8c1164b99e13cf724f704ce/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 236213fa5f45f57f31f0e301901c32793c6402eba8c1164b99e13cf724f704ce/json
< -rw-r--r-- 0/0         3572224 2016-05-26 07:28 236213fa5f45f57f31f0e301901c32793c6402eba8c1164b99e13cf724f704ce/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 260268ab5cff03b357baf6cc8143c140221f86b04c12a7980507f69e6aa0590d/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 260268ab5cff03b357baf6cc8143c140221f86b04c12a7980507f69e6aa0590d/VERSION
< -rw-r--r-- 0/0             388 2016-05-26 07:28 260268ab5cff03b357baf6cc8143c140221f86b04c12a7980507f69e6aa0590d/json
< -rw-r--r-- 0/0       197188096 2016-05-26 07:28 260268ab5cff03b357baf6cc8143c140221f86b04c12a7980507f69e6aa0590d/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 26cd53f278a328606e072512248ddec2abb038cfd03b280fd74d9ffd4071f1c0/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 26cd53f278a328606e072512248ddec2abb038cfd03b280fd74d9ffd4071f1c0/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 26cd53f278a328606e072512248ddec2abb038cfd03b280fd74d9ffd4071f1c0/json
< -rw-r--r-- 0/0         5444096 2016-05-26 07:28 26cd53f278a328606e072512248ddec2abb038cfd03b280fd74d9ffd4071f1c0/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 2ae6aecefa6026a86e67cede6bad2c3f9f44bfde5e3dd8ee726f2b788a0fcf83/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 2ae6aecefa6026a86e67cede6bad2c3f9f44bfde5e3dd8ee726f2b788a0fcf83/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 2ae6aecefa6026a86e67cede6bad2c3f9f44bfde5e3dd8ee726f2b788a0fcf83/json
< -rw-r--r-- 0/0            1024 2016-05-26 07:28 2ae6aecefa6026a86e67cede6bad2c3f9f44bfde5e3dd8ee726f2b788a0fcf83/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 30745fe28146dcdadce3720dbca95bac37a866a1bc412bc26268cb4e35f1b7cf/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 30745fe28146dcdadce3720dbca95bac37a866a1bc412bc26268cb4e35f1b7cf/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 30745fe28146dcdadce3720dbca95bac37a866a1bc412bc26268cb4e35f1b7cf/json
< -rw-r--r-- 0/0            1024 2016-05-26 07:28 30745fe28146dcdadce3720dbca95bac37a866a1bc412bc26268cb4e35f1b7cf/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 335d6b764b5a6dff9eb2ea0de4d651d806821be37d515647dcff57f77257fb44/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 335d6b764b5a6dff9eb2ea0de4d651d806821be37d515647dcff57f77257fb44/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 335d6b764b5a6dff9eb2ea0de4d651d806821be37d515647dcff57f77257fb44/json
< -rw-r--r-- 0/0           18944 2016-05-26 07:28 335d6b764b5a6dff9eb2ea0de4d651d806821be37d515647dcff57f77257fb44/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 33ecd24b9a70937920d3d1f7e2b074f5567f162a7b0d83888312453360abfa37/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 33ecd24b9a70937920d3d1f7e2b074f5567f162a7b0d83888312453360abfa37/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 33ecd24b9a70937920d3d1f7e2b074f5567f162a7b0d83888312453360abfa37/json
< -rw-r--r-- 0/0        21817856 2016-05-26 07:28 33ecd24b9a70937920d3d1f7e2b074f5567f162a7b0d83888312453360abfa37/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 3c698315eed0d141002555d4170430130201ed08a21ef2cc2997a03c4e022f19/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 3c698315eed0d141002555d4170430130201ed08a21ef2cc2997a03c4e022f19/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 3c698315eed0d141002555d4170430130201ed08a21ef2cc2997a03c4e022f19/json
< -rw-r--r-- 0/0            1024 2016-05-26 07:28 3c698315eed0d141002555d4170430130201ed08a21ef2cc2997a03c4e022f19/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 3e8b0ec9e6d6fc697f34586947454a1d4cbf524fcd65883adef577456f6e0078/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 3e8b0ec9e6d6fc697f34586947454a1d4cbf524fcd65883adef577456f6e0078/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 3e8b0ec9e6d6fc697f34586947454a1d4cbf524fcd65883adef577456f6e0078/json
< -rw-r--r-- 0/0            4096 2016-05-26 07:28 3e8b0ec9e6d6fc697f34586947454a1d4cbf524fcd65883adef577456f6e0078/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 5f7e21d7662c8645ab1521ab67f16f7700d6d3b8636922c684851b2578adca99/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 5f7e21d7662c8645ab1521ab67f16f7700d6d3b8636922c684851b2578adca99/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 5f7e21d7662c8645ab1521ab67f16f7700d6d3b8636922c684851b2578adca99/json
< -rw-r--r-- 0/0       238475776 2016-05-26 07:28 5f7e21d7662c8645ab1521ab67f16f7700d6d3b8636922c684851b2578adca99/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 65c5226e37ca87a3a4992ae3996f10c9a33027f5f6c8c4acfbd9a38619bc1b6b/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 65c5226e37ca87a3a4992ae3996f10c9a33027f5f6c8c4acfbd9a38619bc1b6b/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 65c5226e37ca87a3a4992ae3996f10c9a33027f5f6c8c4acfbd9a38619bc1b6b/json
< -rw-r--r-- 0/0           56320 2016-05-26 07:28 65c5226e37ca87a3a4992ae3996f10c9a33027f5f6c8c4acfbd9a38619bc1b6b/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 66f8af51a7bbc7072e8dc14b48cf62fa83ae38c11dcd88bc41a66a2e5a5982d9/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 66f8af51a7bbc7072e8dc14b48cf62fa83ae38c11dcd88bc41a66a2e5a5982d9/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 66f8af51a7bbc7072e8dc14b48cf62fa83ae38c11dcd88bc41a66a2e5a5982d9/json
< -rw-r--r-- 0/0          208896 2016-05-26 07:28 66f8af51a7bbc7072e8dc14b48cf62fa83ae38c11dcd88bc41a66a2e5a5982d9/layer.tar
< -rw-r--r-- 0/0            7707 2016-05-26 07:28 6bf32e4d1697e8cb7ba01c2353fab6b32bc40ba4eda18fe2a20bc0721d05807d.json
< drwxr-xr-x 0/0               0 2016-05-26 07:28 880b98b0a99e5777fa971bbd2c3eaf2eb7665892f7a121d197aec56877d3b45d/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 880b98b0a99e5777fa971bbd2c3eaf2eb7665892f7a121d197aec56877d3b45d/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 880b98b0a99e5777fa971bbd2c3eaf2eb7665892f7a121d197aec56877d3b45d/json
< -rw-r--r-- 0/0            3584 2016-05-26 07:28 880b98b0a99e5777fa971bbd2c3eaf2eb7665892f7a121d197aec56877d3b45d/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 8e08a6be6b25bb02d46831a9932d7dfbeae6c82ca0f3b692e86f7f7f07337a8d/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 8e08a6be6b25bb02d46831a9932d7dfbeae6c82ca0f3b692e86f7f7f07337a8d/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 8e08a6be6b25bb02d46831a9932d7dfbeae6c82ca0f3b692e86f7f7f07337a8d/json
< -rw-r--r-- 0/0       111357952 2016-05-26 07:28 8e08a6be6b25bb02d46831a9932d7dfbeae6c82ca0f3b692e86f7f7f07337a8d/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 a50661851fd32920e8bb403e2b6f946909525e54ca618e86926ee0757922456c/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 a50661851fd32920e8bb403e2b6f946909525e54ca618e86926ee0757922456c/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 a50661851fd32920e8bb403e2b6f946909525e54ca618e86926ee0757922456c/json
< -rw-r--r-- 0/0            8704 2016-05-26 07:28 a50661851fd32920e8bb403e2b6f946909525e54ca618e86926ee0757922456c/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 b35599cdf4656791769178520e212663459c779cde7ba19d552222915a7bea75/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 b35599cdf4656791769178520e212663459c779cde7ba19d552222915a7bea75/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 b35599cdf4656791769178520e212663459c779cde7ba19d552222915a7bea75/json
< -rw-r--r-- 0/0            1024 2016-05-26 07:28 b35599cdf4656791769178520e212663459c779cde7ba19d552222915a7bea75/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 bfb3fe1d9e3a26f8b254e6ad55fc8137d00dc8537d07fc0b310b2573a937e070/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 bfb3fe1d9e3a26f8b254e6ad55fc8137d00dc8537d07fc0b310b2573a937e070/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 bfb3fe1d9e3a26f8b254e6ad55fc8137d00dc8537d07fc0b310b2573a937e070/json
< -rw-r--r-- 0/0            2048 2016-05-26 07:28 bfb3fe1d9e3a26f8b254e6ad55fc8137d00dc8537d07fc0b310b2573a937e070/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 dafc0e15800e138c9fbf9482776fcfdf05f038e7998c520507c91160482e3e21/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 dafc0e15800e138c9fbf9482776fcfdf05f038e7998c520507c91160482e3e21/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 dafc0e15800e138c9fbf9482776fcfdf05f038e7998c520507c91160482e3e21/json
< -rw-r--r-- 0/0            4608 2016-05-26 07:28 dafc0e15800e138c9fbf9482776fcfdf05f038e7998c520507c91160482e3e21/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 f6dc78cbd77eb5558062656b085e3fc93facf6b6fa14ae95e08d88d84142e56b/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 f6dc78cbd77eb5558062656b085e3fc93facf6b6fa14ae95e08d88d84142e56b/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 f6dc78cbd77eb5558062656b085e3fc93facf6b6fa14ae95e08d88d84142e56b/json
< -rw-r--r-- 0/0       123002880 2016-05-26 07:28 f6dc78cbd77eb5558062656b085e3fc93facf6b6fa14ae95e08d88d84142e56b/layer.tar
< drwxr-xr-x 0/0               0 2016-05-26 07:28 ff5701baf37285c9db4498a2fc4462533d2285eb10c51bf446b10e6a25282838/
< -rw-r--r-- 0/0               3 2016-05-26 07:28 ff5701baf37285c9db4498a2fc4462533d2285eb10c51bf446b10e6a25282838/VERSION
< -rw-r--r-- 0/0             464 2016-05-26 07:28 ff5701baf37285c9db4498a2fc4462533d2285eb10c51bf446b10e6a25282838/json
< -rw-r--r-- 0/0            1024 2016-05-26 07:28 ff5701baf37285c9db4498a2fc4462533d2285eb10c51bf446b10e6a25282838/layer.tar
< -rw-r--r-- 0/0            1828 1969-12-31 19:00 manifest.json
< -rw-r--r-- 0/0              98 1969-12-31 19:00 repositories
---
> drwxr-xr-x 0/0               0 2016-05-26 06:58 260268ab5cff03b357baf6cc8143c140221f86b04c12a7980507f69e6aa0590d/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 260268ab5cff03b357baf6cc8143c140221f86b04c12a7980507f69e6aa0590d/VERSION
> -rw-r--r-- 0/0             388 2016-05-26 06:58 260268ab5cff03b357baf6cc8143c140221f86b04c12a7980507f69e6aa0590d/json
> -rw-r--r-- 0/0       197188096 2016-05-26 06:58 260268ab5cff03b357baf6cc8143c140221f86b04c12a7980507f69e6aa0590d/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 2ae6aecefa6026a86e67cede6bad2c3f9f44bfde5e3dd8ee726f2b788a0fcf83/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 2ae6aecefa6026a86e67cede6bad2c3f9f44bfde5e3dd8ee726f2b788a0fcf83/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 2ae6aecefa6026a86e67cede6bad2c3f9f44bfde5e3dd8ee726f2b788a0fcf83/json
> -rw-r--r-- 0/0            1024 2016-05-26 06:58 2ae6aecefa6026a86e67cede6bad2c3f9f44bfde5e3dd8ee726f2b788a0fcf83/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 30745fe28146dcdadce3720dbca95bac37a866a1bc412bc26268cb4e35f1b7cf/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 30745fe28146dcdadce3720dbca95bac37a866a1bc412bc26268cb4e35f1b7cf/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 30745fe28146dcdadce3720dbca95bac37a866a1bc412bc26268cb4e35f1b7cf/json
> -rw-r--r-- 0/0            1024 2016-05-26 06:58 30745fe28146dcdadce3720dbca95bac37a866a1bc412bc26268cb4e35f1b7cf/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 32b550a56e06bd62901e693489144fb772acb06b233a57ebc4a3ed343d117dd7/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 32b550a56e06bd62901e693489144fb772acb06b233a57ebc4a3ed343d117dd7/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 32b550a56e06bd62901e693489144fb772acb06b233a57ebc4a3ed343d117dd7/json
> -rw-r--r-- 0/0           18944 2016-05-26 06:58 32b550a56e06bd62901e693489144fb772acb06b233a57ebc4a3ed343d117dd7/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 33ecd24b9a70937920d3d1f7e2b074f5567f162a7b0d83888312453360abfa37/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 33ecd24b9a70937920d3d1f7e2b074f5567f162a7b0d83888312453360abfa37/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 33ecd24b9a70937920d3d1f7e2b074f5567f162a7b0d83888312453360abfa37/json
> -rw-r--r-- 0/0        21817856 2016-05-26 06:58 33ecd24b9a70937920d3d1f7e2b074f5567f162a7b0d83888312453360abfa37/layer.tar
> -rw-r--r-- 0/0            7708 2016-05-26 06:58 34cc625cad1afe8d62e3764650590384459142e93dedb384b669fe0b1bc5bf6b.json
> drwxr-xr-x 0/0               0 2016-05-26 06:58 3f5766e4da704384907ca6e35473a2e0893b9ec14b3797ac8976c1030719ff9b/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 3f5766e4da704384907ca6e35473a2e0893b9ec14b3797ac8976c1030719ff9b/VERSION
> -rw-r--r-- 0/0            1289 2016-05-26 06:58 3f5766e4da704384907ca6e35473a2e0893b9ec14b3797ac8976c1030719ff9b/json
> -rw-r--r-- 0/0            1024 2016-05-26 06:58 3f5766e4da704384907ca6e35473a2e0893b9ec14b3797ac8976c1030719ff9b/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 5f7e21d7662c8645ab1521ab67f16f7700d6d3b8636922c684851b2578adca99/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 5f7e21d7662c8645ab1521ab67f16f7700d6d3b8636922c684851b2578adca99/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 5f7e21d7662c8645ab1521ab67f16f7700d6d3b8636922c684851b2578adca99/json
> -rw-r--r-- 0/0       238475776 2016-05-26 06:58 5f7e21d7662c8645ab1521ab67f16f7700d6d3b8636922c684851b2578adca99/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 65c5226e37ca87a3a4992ae3996f10c9a33027f5f6c8c4acfbd9a38619bc1b6b/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 65c5226e37ca87a3a4992ae3996f10c9a33027f5f6c8c4acfbd9a38619bc1b6b/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 65c5226e37ca87a3a4992ae3996f10c9a33027f5f6c8c4acfbd9a38619bc1b6b/json
> -rw-r--r-- 0/0           56320 2016-05-26 06:58 65c5226e37ca87a3a4992ae3996f10c9a33027f5f6c8c4acfbd9a38619bc1b6b/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 66f8af51a7bbc7072e8dc14b48cf62fa83ae38c11dcd88bc41a66a2e5a5982d9/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 66f8af51a7bbc7072e8dc14b48cf62fa83ae38c11dcd88bc41a66a2e5a5982d9/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 66f8af51a7bbc7072e8dc14b48cf62fa83ae38c11dcd88bc41a66a2e5a5982d9/json
> -rw-r--r-- 0/0          208896 2016-05-26 06:58 66f8af51a7bbc7072e8dc14b48cf62fa83ae38c11dcd88bc41a66a2e5a5982d9/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 72c44aa6ce98f2eff3a2c2dd2eb7e1beebfbc264addf04d95ef5accc0d923d22/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 72c44aa6ce98f2eff3a2c2dd2eb7e1beebfbc264addf04d95ef5accc0d923d22/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 72c44aa6ce98f2eff3a2c2dd2eb7e1beebfbc264addf04d95ef5accc0d923d22/json
> -rw-r--r-- 0/0            2048 2016-05-26 06:58 72c44aa6ce98f2eff3a2c2dd2eb7e1beebfbc264addf04d95ef5accc0d923d22/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 85ee0b41a0f7bb2b4f24234db6f2b42cc79c551c70fa86a3968989b2d905be2f/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 85ee0b41a0f7bb2b4f24234db6f2b42cc79c551c70fa86a3968989b2d905be2f/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 85ee0b41a0f7bb2b4f24234db6f2b42cc79c551c70fa86a3968989b2d905be2f/json
> -rw-r--r-- 0/0            4096 2016-05-26 06:58 85ee0b41a0f7bb2b4f24234db6f2b42cc79c551c70fa86a3968989b2d905be2f/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 880b98b0a99e5777fa971bbd2c3eaf2eb7665892f7a121d197aec56877d3b45d/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 880b98b0a99e5777fa971bbd2c3eaf2eb7665892f7a121d197aec56877d3b45d/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 880b98b0a99e5777fa971bbd2c3eaf2eb7665892f7a121d197aec56877d3b45d/json
> -rw-r--r-- 0/0            3584 2016-05-26 06:58 880b98b0a99e5777fa971bbd2c3eaf2eb7665892f7a121d197aec56877d3b45d/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 8e08a6be6b25bb02d46831a9932d7dfbeae6c82ca0f3b692e86f7f7f07337a8d/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 8e08a6be6b25bb02d46831a9932d7dfbeae6c82ca0f3b692e86f7f7f07337a8d/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 8e08a6be6b25bb02d46831a9932d7dfbeae6c82ca0f3b692e86f7f7f07337a8d/json
> -rw-r--r-- 0/0       111357952 2016-05-26 06:58 8e08a6be6b25bb02d46831a9932d7dfbeae6c82ca0f3b692e86f7f7f07337a8d/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 a14100c07367c5e5538fc3bdbbed2d0ef0485f1bbd0381f93dc32f59aec7605a/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 a14100c07367c5e5538fc3bdbbed2d0ef0485f1bbd0381f93dc32f59aec7605a/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 a14100c07367c5e5538fc3bdbbed2d0ef0485f1bbd0381f93dc32f59aec7605a/json
> -rw-r--r-- 0/0         5444096 2016-05-26 06:58 a14100c07367c5e5538fc3bdbbed2d0ef0485f1bbd0381f93dc32f59aec7605a/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 a50661851fd32920e8bb403e2b6f946909525e54ca618e86926ee0757922456c/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 a50661851fd32920e8bb403e2b6f946909525e54ca618e86926ee0757922456c/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 a50661851fd32920e8bb403e2b6f946909525e54ca618e86926ee0757922456c/json
> -rw-r--r-- 0/0            8704 2016-05-26 06:58 a50661851fd32920e8bb403e2b6f946909525e54ca618e86926ee0757922456c/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 b35599cdf4656791769178520e212663459c779cde7ba19d552222915a7bea75/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 b35599cdf4656791769178520e212663459c779cde7ba19d552222915a7bea75/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 b35599cdf4656791769178520e212663459c779cde7ba19d552222915a7bea75/json
> -rw-r--r-- 0/0            1024 2016-05-26 06:58 b35599cdf4656791769178520e212663459c779cde7ba19d552222915a7bea75/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 c891d716fada3ef0b397d61857096dc14d0ecb2279be9625c65a9635dca6f3c3/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 c891d716fada3ef0b397d61857096dc14d0ecb2279be9625c65a9635dca6f3c3/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 c891d716fada3ef0b397d61857096dc14d0ecb2279be9625c65a9635dca6f3c3/json
> -rw-r--r-- 0/0            4096 2016-05-26 06:58 c891d716fada3ef0b397d61857096dc14d0ecb2279be9625c65a9635dca6f3c3/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 dafc0e15800e138c9fbf9482776fcfdf05f038e7998c520507c91160482e3e21/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 dafc0e15800e138c9fbf9482776fcfdf05f038e7998c520507c91160482e3e21/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 dafc0e15800e138c9fbf9482776fcfdf05f038e7998c520507c91160482e3e21/json
> -rw-r--r-- 0/0            4608 2016-05-26 06:58 dafc0e15800e138c9fbf9482776fcfdf05f038e7998c520507c91160482e3e21/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 dafea035d1b9b17e02ad9129c2192d8c816b5a95cdb84e715c3fb3f4a074ff4e/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 dafea035d1b9b17e02ad9129c2192d8c816b5a95cdb84e715c3fb3f4a074ff4e/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 dafea035d1b9b17e02ad9129c2192d8c816b5a95cdb84e715c3fb3f4a074ff4e/json
> -rw-r--r-- 0/0         3572224 2016-05-26 06:58 dafea035d1b9b17e02ad9129c2192d8c816b5a95cdb84e715c3fb3f4a074ff4e/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 dc00c85eef2c74c07f0098eddf479317cdf8bd59dabd5fe75b2da99d718e363f/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 dc00c85eef2c74c07f0098eddf479317cdf8bd59dabd5fe75b2da99d718e363f/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 dc00c85eef2c74c07f0098eddf479317cdf8bd59dabd5fe75b2da99d718e363f/json
> -rw-r--r-- 0/0            1024 2016-05-26 06:58 dc00c85eef2c74c07f0098eddf479317cdf8bd59dabd5fe75b2da99d718e363f/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 f6dc78cbd77eb5558062656b085e3fc93facf6b6fa14ae95e08d88d84142e56b/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 f6dc78cbd77eb5558062656b085e3fc93facf6b6fa14ae95e08d88d84142e56b/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 f6dc78cbd77eb5558062656b085e3fc93facf6b6fa14ae95e08d88d84142e56b/json
> -rw-r--r-- 0/0       123002880 2016-05-26 06:58 f6dc78cbd77eb5558062656b085e3fc93facf6b6fa14ae95e08d88d84142e56b/layer.tar
> drwxr-xr-x 0/0               0 2016-05-26 06:58 ff5701baf37285c9db4498a2fc4462533d2285eb10c51bf446b10e6a25282838/
> -rw-r--r-- 0/0               3 2016-05-26 06:58 ff5701baf37285c9db4498a2fc4462533d2285eb10c51bf446b10e6a25282838/VERSION
> -rw-r--r-- 0/0             464 2016-05-26 06:58 ff5701baf37285c9db4498a2fc4462533d2285eb10c51bf446b10e6a25282838/json
> -rw-r--r-- 0/0            1024 2016-05-26 06:58 ff5701baf37285c9db4498a2fc4462533d2285eb10c51bf446b10e6a25282838/layer.tar
> -rw-r--r-- 0/0            1833 1969-12-31 19:00 manifest.json
> -rw-r--r-- 0/0             103 1969-12-31 19:00 repositories

If it's something wrong with my docker (beta) on a Mac, then it's fine. :) As you can see above, there's a difference between the images. File sizes seem the same, but the times, etc. are different.

zabil commented

So, latest and 16.5.0 have different IDs. I think we should fix the pipeline which does the tagging/creating and push from there.

I changed the pipeline to have 16.5.0 tags with this commit cdf2a6c it auto triggered, however it failed while pushing the agent as we have a 16.5.0 tag saying

docker tag gocd/gocd-agent gocd/gocd-agent:16.5.0
Error response from daemon: Conflict: Tag 16.5.0 is already set to image d86c2afa71590555a544511cf5bf0b87b96cf358ab52252833d17bfdbcbf9858, if you want to replace it, please use -f option
rake aborted!

Do a -f ?

It seems to be broken on docker hub itself, as far as I can see. Can you run the commands mentioned at #39 (comment) to see if you see consistent image IDs for all the tags?

Gah. Didn't read it properly. Sorry. You asked about adding -f. Can we make it an option to the pipeline? If not, let's add -f for one run, please.

zabil commented

According to the documentation that option is not there. I wonder what the message meant.
https://docs.docker.com/engine/reference/commandline/push/