godotengine/godot

LSP and DAP connections are not terminating

rsubtil opened this issue · 0 comments

Godot version

latest

System information

Arch Linux

Issue description

Note
this issue was reported by @glimpsebeyond, @kkhhaann and others on godot-vscode-plugin

Since #59582, LSP and DAP clients aren't properly disconnected from Godot as the status isn't updated with a poll call. This eventually makes it reach the clients limit (8), and refuse further connections. This issue is more problematic for DAP as connections are almost always reset for every new debugging session.

image

Steps to reproduce

  • Open a project with an external tool and either use LSP (code completion) or DAP (debugging) protocol from Godot
  • Notice that Godot receives connections ([LSP] Connection taken), but doesn't disconnect clients when they disappear (no [LSP] Disconnected message)
  • Reload external tools to reconnect, until the limit is reached and no more clients are accepted

Minimal reproduction project

N/A