goffrie/plex

Rust stable

aptakhin opened this issue · 20 comments

Hi!

I'm not very familiar with Rust, but very excited by your library. Only my problem is I decided to keep on latest stable Rust.
Is it very difficult to support stable Rust at least lexer part?

Hi! It should be possible, but I'm not currently working on it. I'm not very happy with the current options for stable, so I'm going to wait a little at least.

Hi, what's the status on this issue again?
Also, what rust version are you building on? I just encountered a significant number of errors on cargo build's compilation of plex. I'm on Gentoo's nightly branch of rust.

Thanks for the quick reply!
I'm just starting with rust right now, so perhaps this may be beyond me. But I can try.
Update: Initial impressions while fixing => Major changes in rust's syntax crate.

I'm having a look at this now, too. Mostly it just seems to be renaming and some minor reworks of syntax.

Down to 5 compile errors (from ~50), so I'll let you know if I get there! 😸

Oh, damn. I wasn't working on the latest master. -_- I'll be a little bit more.

Turns out I redid a lot of work. PR incoming.

Great! I'll test it out soon. Although, are you informed enough to be able to port it to stable? (In case you would prefer that as well). There's this library rustlex which works on both. Perhaps something like that can be made for this, if possible? I'm quite new to rust, and low on time, so cannot make that work right now. No hurry though 😄

Unfortunately not; I'm very advanced at Rust either, and I do think it would be a biiiig effort to port this; better waiting for the features to come to stable (or ideally, target nightly yourself).

I wouldn't target a nightly build I'm afraid. But is it safe to assume (from, for instance, here ) that macros 1.1 should be in stable within a week or two? That's what is holding back plex from building on stable, right?

Has anybody built successfully with a stable version compiler?

Has anybody built successfully with a stable version compiler?

As long as the procedural macros aren't stabilized yet, I don't think you can build this crate with stable (or even beta).

See this issue for more info: rust-lang/rust#54725

maxrdz commented

I see that rust-lang/rust#54725 is still in nightly and under active development to this day. Since the last activity in this repository was in 2020, I wanted to ask if the maintainers are still looking to update this crate once this feature is on rust stable?

I am using this crate for a network engine project and the only reason why I'm building with nightly rust is to make use of plex. Hoping to switch back to stable rust as soon as I can.

I ported the crate to use syn 2.0.0 and compile_error!-style error reporting (using syn::Error) in fafa4dc. With that, the crate now compiles on stable.

maxrdz commented

Thank you! 😊

maxrdz commented

Would it be possible to make a new release with this feature? Would be great if I can build my project with the latest version of the crate without needing to compile from source. Thank you :)

@maxrdz v0.3 was just released!

maxrdz commented