Code and gemspec mismatch for json-jruby
Closed this issue · 5 comments
The latest gem has a mismatch in the code (1.4.2) and gemspec (1.1.0).
@kaiwren I bumped up the version of json-jruby in that commit. In wrest.rb it was
RUBY_PLATFORM =~ /java/ ? gem('json-jruby', '>= 1.4.2') : gem('json', '>= 1.4.2')
Which I have fixed in bb46649. Though this shouldn't cause a problem because of the '>='
Before releasing we might want to build on 'json' gem as well, as 1.5.1 is available.
~opensource/wrest(master)$
rake
ruby-1.9.2-p180@wrest
(in /Users/niranjan/Work/ruby/ror/opensource/wrest)
Building on Ruby 1.9.2, 2011-02-18, x86_64-darwin10.6.0
Hanna not available, using standard Rake rdoctask. Install it with: gem
install mislav-hanna.
/Users/niranjan/.rvm/rubies/ruby-1.9.2-p180/bin/ruby -S bundle exec rspec
spec/wrest/async_request/event_machine_backend_spec.rb
spec/wrest/async_request/thread_backend_spec.rb
spec/wrest/async_request_spec.rb spec/wrest/cache_proxy_spec.rb
spec/wrest/caching/memcached_spec.rb spec/wrest/caching_spec.rb
spec/wrest/callback_spec.rb
spec/wrest/components/container/alias_accessors_spec.rb
spec/wrest/components/container/typecaster_spec.rb
spec/wrest/components/container_spec.rb
spec/wrest/components/mutators/base_spec.rb
spec/wrest/components/mutators/camel_to_snake_spec.rb
spec/wrest/components/mutators/xml_mini_type_caster_spec.rb
spec/wrest/components/mutators/xml_simple_type_caster_spec.rb
spec/wrest/components/mutators_spec.rb
spec/wrest/components/translators/json_spec.rb
spec/wrest/components/translators/xml_spec.rb
spec/wrest/components/translators_spec.rb
spec/wrest/core_ext/hash/conversions_spec.rb
spec/wrest/core_ext/string/conversions_spec.rb
spec/wrest/curl/post_multipart_spec.rb spec/wrest/curl/post_spec.rb
spec/wrest/curl/put_multipart_spec.rb spec/wrest/curl/request_spec.rb
spec/wrest/curl/response_spec.rb
spec/wrest/hash_with_case_insensitive_access_spec.rb
spec/wrest/http/response_spec.rb spec/wrest/http_codes_spec.rb
spec/wrest/native/get_spec.rb spec/wrest/native/post_multipart_spec.rb
spec/wrest/native/redirection_spec.rb spec/wrest/native/request_spec.rb
spec/wrest/native/response_spec.rb spec/wrest/native/session_spec.rb
spec/wrest/uri_spec.rb spec/wrest/uri_template_spec.rb
spec/wrest/xml_mini/jdom/xpath_filter_spec.rb
spec/wrest/xml_mini/jdom_spec.rb
spec/wrest/xml_mini/libxml/xpath_filter_spec.rb
spec/wrest/xml_mini/libxml_spec.rb
spec/wrest/xml_mini/nokogiri/xpath_filter_spec.rb
spec/wrest/xml_mini/nokogiri_spec.rb
spec/wrest/xml_mini/rexml/xpath_filter_spec.rb
spec/wrest/xml_mini/rexml_spec.rb
Run filtered using {:functional=>nil}
....................................................................................................................................................................................................................................................................................................................................................................................
Finished in 2.67 seconds
372 examples, 0 failures
~opensource/wrest(master)$
Regards,
Niranjan Paranjape.
On Tue, Apr 5, 2011 at 1:28 AM, kaiwren <
reply@reply.github.com>wrote:
One of commits between d314a83 and
bb46649 seems to have massively killed the
build on 1.9.2. Will sort it out and get back to you.Reply to this email directly or view it on GitHub:
https://github.com/kaiwren/wrest/issues/102#comment_955733