gojek/ziggurat

Send an appropriate response message when topic-entity is wrong while getting dead set messages

mjayprateek opened this issue · 2 comments

Example:
curl -X GET 'http://localhost:8080/v1/dead_set?count=1&topic-entity=wrong-one'
{"error":"Count should be the positive integer and topic entity/ channel should be present"}

Correct Message should be something like: "topic-entity is wrong. please provide the correct data"

@mjayprateek would changing the string to the correct message be enough to close this issue?

@macalimlim No, I don't think so. Upon looking at the code, I found that if any of the topic-entity, channel or count is not valid, it shows the same error. I think it's best to handle each case individually.