Ziggurat `with-retry` macro retries it n+1 times instead of n
shubham7saxena opened this issue · 1 comments
shubham7saxena commented
https://github.com/gojek/ziggurat/blob/master/src/ziggurat/retry.clj#L16
we check for (if-not (zero? count))
. for example I say, 5 retries. it will decrement the retry-count in the order of 5,4,3,2,1,0 (six retries) and on the sixth retry, it will throw the exception.
we could check for positivity of counter and then throw the exception
kartik7153 commented
1 time is valid try and then it retries for x number of times.
Closing this issue.