--with-orchestrator is not working as expected

Question

--with-orchestrator is not working as expected

Closed this issue 5 years ago · 5 comments

The documentation says the argument should be true or false but it's not true:

$ java -jar composer.jar --apk /any/path/debug-androidTest.apk --test-apk /any/path/debug-androidTest.apk --output-directory /any/path --verbose-output true --with-orchestrator true
Exception in thread "main" com.beust.jcommander.ParameterException: Was passed main parameter 'true' but no main parameter was defined in your arg class
        at com.beust.jcommander.JCommander.getMainParameter(JCommander.java:887)
        at com.beust.jcommander.JCommander.parseValues(JCommander.java:705)
        at com.beust.jcommander.JCommander.parse(JCommander.java:312)
        at com.beust.jcommander.JCommander.parse(JCommander.java:291)
        at com.gojuno.composer.ArgsKt.parseArgs(Args.kt:138)
        at com.gojuno.composer.MainKt.main(Main.kt:34)

( I removed the paths of the apk because they are irrelevant )

as soon as I remove the last true from the command it works as a charm

I was going to open the PR to the gradle plugin adding it, but now I don't know what should I do.

any comment to add @jonas-m- ? Am I missing something?

Answer 1 · 2018-10-17T15:33:12.000Z

Will try to take a look in ~5 hours, but it seems that it's an error in documentation only. Will reply as soon as I have an answer

Answer 2 · 2018-10-17T19:53:53.000Z

Confirmed: just a problem with documentation.

In my PR, I've based my argument documentation on an existing --keep-output-on-exit. And sure enough - just checked - it also doesn't behave as documented: presence of the parameter flag itself acts as true, without it accepting any arguments

Answer 3 · 2018-10-17T20:47:54.000Z

Then fixing the documentation would close this issue.
Thanks for checking it!

Answer 4 · 2018-10-18T09:22:13.000Z

it may be a different issue, but we are missing the clearPackageData so just orchestrator is not enough for us

Answer 5 · 2019-03-18T17:12:05.000Z

it may be a different issue, but we are missing the clearPackageData so just orchestrator is not enough for us

clearPackageData as instrumentation runner argument is supported by composer without changes already:

java -jar composer-latest-version.jar \
--apk app/build/outputs/apk/example-debug.apk \
--test-apk app/build/outputs/apk/example-debug-androidTest.apk \
--instrumentation-arguments clearPackageData true \
--with-orchestrator true