gokulkrishh/demo-progressive-web-app

Clarification sw

asvny opened this issue ยท 3 comments

asvny commented

https://github.com/annamalai-saro/demo-progressive-web-app/blob/master/serviceWorker.js#L65-L69

I think the code should be

caches.open(staticCache).then(function(cache) {
     cache.put(request, response.clone());
});

return response;

then at https://github.com/annamalai-saro/demo-progressive-web-app/blob/master/serviceWorker.js#L56

event.respondWith is missing ...

Sorry ..Please correct me if I am wrong ...

Ooopsy, I missed it. You are right on both the things

asvny commented

@gokulkrishh Okaay ๐Ÿ‘ ! BTW #pwa in bangalore was great ๐Ÿ˜„

@annamalai-saro Good to know that you found it useful ๐Ÿ‘