golang-design/hotkey

[Windows] Unregister requires hotkey press to complete

ventsislav-georgiev opened this issue · 3 comments

ventsislav-georgiev commented

I hit this issue and then I saw that it is noted in the code:

hotkey/hotkey_windows.go

Line 82 in 258b6bc

// KNOWN ISSUE: This message loop need to press an additional

Posting here for visibility.

changkun commented

https://github.com/golang-design/hotkey/releases/tag/v0.3.0 should have resolved all observable issues.

ventsislav-georgiev commented

Thanks! Properly unregisters now for Windows.

On another note, I noticed that on Mac the runOnMain for register is no longer required. The hotkeys can be registered from any goroutine. I guess the proposal in the fyne repo is redundant then?

changkun commented

I guess the proposal in the fyne repo is redundant then?

That's not true. The proposal can also help platforms such as iOS or Android, which are not covered in our case. Any calls that require mainthread, not necessarily on macOS, could benifit from that.

  • 👍1