golang/dep

-old flag for dep status command is not implemented.

Closed this issue · 4 comments

dmitshur commented

The only mentions of old value are:

dep/cmd/dep/status.go

Line 56 in edc545f

fs.BoolVar(&cmd.old, "old", false, "only show out-of-date dependencies")

And:

dep/cmd/dep/status.go

Line 68 in edc545f

old bool

So, dep status and dep status -old produce identical output.

Is it not implemented because this is a known TODO?

dmitshur commented

When you run dep status -detailed, you at least get a helpful error message:

$ dep status -detailed
not implemented

Doing nothing for -old is misleading because it's not immediately obvious from output that even non-old entries are being shown. So a short term solution is to fail with "not implemented" error message.

adamo57 commented

I could take this on.

darkowlzz commented

@shurcooL thanks for a push. Status is getting the next development focus. We already have PR #613 with implementation of -old and other similar flags. We are still working out the details of all the status run modes.

We can add not implemented to the unimplemented flags, if that helps for now. @adamo57 you're welcome to send a PR for that :)

dmitshur commented

I see, if it's already being worked on, that sounds good. Thanks. I'd suggest adding a Resolves #1046. sentence to that PR description to make the association.