golang/gddo

Remove `Uses` links to sourcegraph

s-mang opened this issue · 1 comments

When the Uses links first appeared on godoc.org, I believe they used to show uses of the identifier in open-source code external to its own package via SourceGraph.
This used to be really helpful - an easy way to find examples.

Maybe SourceGraph's pricing model changed, such that you need to be a paying customer to access uses in external code.

In any case, the links currently show uses in the current package, which is not very helpful (IMHO). When uses of exported identifiers in the current package do come up, they are typically just being wrapped lightly.

I propose we remove these links. Reduce clutter of codebase + UI.

cc @shurcooL @shantuo

So sorry that we @sourcegraph didn't see this earlier. (For future reference, you can ping me or @sqs and we'll see it and respond quickly)

We're working on displaying the external references tab automatically when you click these links. To be clear, this change had nothing to do with pricing changes or anything like that. In fact, when you land on the page, you can actually select the external references tab yourself just by clicking the External References button:

image

The reason that we changed this behavior by default is because we know external reference finding is a bit slow to load today. Finding references in a single repo is a bit quicker and often turns up decent results in tests, etc.

We're hoping that once we're finished revamping our language support, we can work on having this be much snappier and change this back to the external references tab by default.

Also, I don't have exact numbers on hand at the moment (I can grab them and share if desirable), but I do know these links are used a few thousand times per month.