golang/gddo

Talks doesn't support .background

nezorflame opened this issue · 13 comments

nezorflame commented

Host any present slide with .background image.
It won't be shown for your presentation.
Other images seem to work fine.

Is this a bug or feature?

dmitshur commented

Is this an issue with the present command? Or just talks.godoc.org?

nezorflame commented

Background works fine when present is launched locally.

  • 👍1
mmcloughlin commented

I'm seeing this too. There seems to be some re-processing of presentations happening which is not re-mapping .background URLs to point at github instead. See

gddo/gosrc/present.go

Lines 37 to 39 in 9d8ff1c

case "iframe", "image":
data = append(data, b.data[i:m[4]]...)
data = append(data, b.resolveURL(name)...)

Looks like this would not be too hard to fix.

dmitshur commented

@nezorflame (or anyone else), do you know of a sample talk that has a slide with .background that can be used to reproduce the bug?

Deleplace commented

@mmcloughlin I read it and tested it locally, everything works fine on my workstation.

dmitshur commented

The new version is deployed now, so .background should be working. Thank you for the contribution!

Deleplace commented

Thank you @dmitshur . It now works fine on the public URL of my slideshow.

mmcloughlin commented

We can also test this with the sample presentation that was also included in the CL. This was intended to exercise all possible features of the present tool.

https://talks.godoc.org/github.com/golang/gddo/gosrc/testdata/sample.slide

We do indeed see the .background correctly, however it seems the the vector graphic is broken.

  • 👍1
mmcloughlin commented

I'm getting a 403 from https://rawgit.com/golang/gddo/master/gosrc/testdata/gopher.svg

https://rawgit.com says "RawGit has reached the end of its useful life".

  • 👍1