golang/gddo

talksapp: accept markdown-based present files for talks.godoc.org

sbinet opened this issue · 6 comments

CL https://golang.org/cl/222846/ (and following) added support for markdown-based present files (as per golang/go#33955)

it would be great if the present instance running at talks.godoc.org was updated to accept them as well.

See:

@dmitshur was this the right place to file that issue?

Sorry I missed this.

This is indeed the right issue tracker for tracking the work for talksapp.

ping?

AFAIK, it's still using the old, non-markdown compliant, code...

That is true, the work of updating talksapp hasn't been done. I'm not aware of someone planning to do this work soon.

Another factor to consider here is that it's not easy to deploy a new version of talksapp now because its deployment script hasn't been kept up to date, so resolving this issue will require also getting talksapp deployment fixed.

thanks circling back on this.
what would involve updating that deployment script? (ie: could this be done by a non-googler?)

It should be possible, although it's harder because non-Googlers won't have access to the GCP project it's currently deployed to test everything works. But it can be deployed to another project for testing purposes.

The deployment app.yaml file is in talksapp directory. See commit 9bd4a32 for when it was done last time. This time, there are more changes to make because of changes between Go 1.9 and 1.11 runtimes, as documented at https://cloud.google.com/appengine/docs/standard/go111/go-differences.