cmd/go: refactor into multiple packages

Question

cmd/go: refactor into multiple packages

rsc opened this issue 9 years ago · 24 comments

It would help to split the go command into some packages,
in particular to separate out package loading from package building.
I have a plan and will send CLs at the start of Go 1.9
to try to get ahead of any possible merge conflicts.

CLs will be attached to this issue.

Answer 1 · 2017-01-13T19:56:58.000Z

Would this cover the need for https://github.com/kisielk/gotool?

Answer 2 · 2017-02-02T15:05:24.000Z

CL https://golang.org/cl/36192 mentions this issue.

Answer 3 · 2017-02-02T15:05:26.000Z

CL https://golang.org/cl/36129 mentions this issue.

Answer 4 · 2017-02-02T15:05:28.000Z

CL https://golang.org/cl/36193 mentions this issue.

Answer 5 · 2017-02-02T15:05:29.000Z

CL https://golang.org/cl/36203 mentions this issue.

Answer 6 · 2017-02-02T15:05:29.000Z

CL https://golang.org/cl/36195 mentions this issue.

Answer 7 · 2017-02-02T15:05:30.000Z

CL https://golang.org/cl/36191 mentions this issue.

Answer 8 · 2017-02-02T15:05:31.000Z

CL https://golang.org/cl/36204 mentions this issue.

Answer 9 · 2017-02-02T15:05:32.000Z

CL https://golang.org/cl/36200 mentions this issue.

Answer 10 · 2017-02-02T15:05:33.000Z

CL https://golang.org/cl/36199 mentions this issue.

Answer 11 · 2017-02-02T15:05:34.000Z

CL https://golang.org/cl/36202 mentions this issue.

Answer 12 · 2017-02-02T15:05:35.000Z

CL https://golang.org/cl/36194 mentions this issue.

Answer 13 · 2017-02-02T15:05:36.000Z

CL https://golang.org/cl/36196 mentions this issue.

Answer 14 · 2017-02-02T15:05:37.000Z

CL https://golang.org/cl/36190 mentions this issue.

Answer 15 · 2017-02-02T15:05:38.000Z

CL https://golang.org/cl/36198 mentions this issue.

Answer 16 · 2017-02-02T15:05:39.000Z

CL https://golang.org/cl/36201 mentions this issue.

Answer 17 · 2017-02-02T15:05:40.000Z

CL https://golang.org/cl/36197 mentions this issue.

Answer 18 · 2017-02-02T15:09:30.000Z

Would this cover the need for https://github.com/kisielk/gotool?

All the new packages are internal, so it seems like it won't replace gotool just yet.

Answer 19 · 2017-02-02T15:14:45.000Z

There is no intent to expose the internals of the go command for direct import by programs that want to behave like it. I would prefer if those programs invoked the go command to find out what they need to find out: the API is the binary itself, not the Go package. Using the binary means that when some detail of the go command changes, all those other tools don't need to be updated. I'd be happy to talk about what those tools need.

Answer 20 · 2017-02-02T15:15:35.000Z

@rsc this sounds like a good idea. Should I open a separate issue and ping people who'll probably be interested?

Answer 21 · 2017-02-02T15:20:27.000Z

Sure, please open a new issue 'cmd/go: define command-line API for tools' and please list there the kinds of things your tools need to find out from the go command. Thanks.

Answer 22 · 2017-02-02T16:18:21.000Z

I'm very happy about this happening. I've been considering making a proposal and try to motivate doing exactly this. 👍

I'll also mention #11490 here - that issue might be worth revisiting and updating now that this is happening, since it's relevant.

Answer 23 · 2017-05-03T13:22:38.000Z

This happened.

Answer 24 · 2017-08-28T03:26:45.000Z

Change https://golang.org/cl/59430 mentions this issue: cmd/go/internal/load: fix IsMetaPackage function name in doc