x/tools/gopls: crash during SignatureHelp

Question

x/tools/gopls: crash during SignatureHelp

Closed this issue 5 years ago · 2 comments

ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.

Describe what you observed.

I write some code with problem and it crashed.

Please attach the stack trace from the crash.
A window with the error message should have popped up in the lower half of your screen.
Please copy the stack trace from that window and paste it in this issue.

[Info  - 3:32:23 PM] 2020/07/15 15:32:23 background imports cache refresh starting

[Info  - 3:32:23 PM] 2020/07/15 15:32:23 background refresh finished after 460.899124ms

[Info  - 3:33:19 PM] 2020/07/15 15:33:19 background imports cache refresh starting

[Info  - 3:33:19 PM] 2020/07/15 15:33:19 background refresh finished after 125.066717ms

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x13ec3f0]

goroutine 62690 [running]:
golang.org/x/tools/internal/lsp/source.newBuiltinSignature(0x1a68360, 0xc02b980a80, 0x1a7a340, 0xc000522840, 0x18ed2e9, 0x7, 0x36ef2e444c090201, 0xc02f2bde60, 0xc0521e1350)
	/homepath/code/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20200708181441-6004c8539734/internal/lsp/source/types_format.go:82 +0xd0
golang.org/x/tools/internal/lsp/source.builtinSignature(0x1a68360, 0xc02b980a80, 0x1a7a340, 0xc000522840, 0xc017866440, 0x18ed2e9, 0x7, 0x30afddd, 0xc02f1662e0, 0xc0000d5e00, ...)
	/homepath/code/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20200708181441-6004c8539734/internal/lsp/source/signature_help.go:140 +0x81
golang.org/x/tools/internal/lsp/source.SignatureHelp(0x1a68360, 0xc02b980a80, 0x1a7b3a0, 0xc05277ab80, 0x1a6c160, 0xc0124438c0, 0x4040800000000000, 0x4040800000000000, 0x0, 0x0, ...)
	/homepath/code/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20200708181441-6004c8539734/internal/lsp/source/signature_help.go:81 +0x11aa
golang.org/x/tools/internal/lsp.(*Server).signatureHelp(0xc0000b5b80, 0x1a682a0, 0xc01796fc80, 0xc0521c7480, 0x0, 0x0, 0xc0521d8fd0)
	/homepath/code/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20200708181441-6004c8539734/internal/lsp/signature_help.go:21 +0xf6
golang.org/x/tools/internal/lsp.(*Server).SignatureHelp(0xc0000b5b80, 0x1a682a0, 0xc01796fc80, 0xc0521c7480, 0xc0521c7480, 0x0, 0x0)
	/homepath/code/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20200708181441-6004c8539734/internal/lsp/server_gen.go:188 +0x49
golang.org/x/tools/internal/lsp/protocol.serverDispatch(0x1a682a0, 0xc01796fc80, 0x1a82720, 0xc0000b5b80, 0xc02b980390, 0x1a684e0, 0xc01796fbc0, 0x0, 0x0, 0xbfbbca33214a08a0)
	/homepath/code/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20200708181441-6004c8539734/internal/lsp/protocol/tsserver.go:276 +0x494a
golang.org/x/tools/internal/lsp/protocol.ServerHandler.func1(0x1a682a0, 0xc01796fc80, 0xc02b980390, 0x1a684e0, 0xc01796fbc0, 0x0, 0x0)
	/homepath/code/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20200708181441-6004c8539734/internal/lsp/protocol/protocol.go:62 +0xc0
golang.org/x/tools/internal/lsp/lsprpc.handshaker.func1(0x1a682a0, 0xc01796fc80, 0xc02b980390, 0x1a684e0, 0xc01796fbc0, 0x0, 0x0)
	/homepath/code/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20200708181441-6004c8539734/internal/lsp/lsprpc/lsprpc.go:509 +0x40e
golang.org/x/tools/internal/jsonrpc2.MustReplyHandler.func1(0x1a682a0, 0xc01796fc80, 0xc02ef640a0, 0x1a684e0, 0xc01796fbc0, 0x1951b20, 0x0)
	/homepath/code/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20200708181441-6004c8539734/internal/jsonrpc2/handler.go:35 +0xd3
golang.org/x/tools/internal/jsonrpc2.AsyncHandler.func1.2(0xc052b4d6e0, 0xc02ac72de0, 0xc0000a94c0, 0x1a682a0, 0xc01796fc80, 0xc02ef640a0, 0x1a684e0, 0xc01796fbc0)
	/homepath/code/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20200708181441-6004c8539734/internal/jsonrpc2/handler.go:103 +0x86
created by golang.org/x/tools/internal/jsonrpc2.AsyncHandler.func1
	/homepath/code/gopath/pkg/mod/golang.org/x/tools@v0.0.0-20200708181441-6004c8539734/internal/jsonrpc2/handler.go:100 +0x171
[Error - 3:33:32 PM] Connection to server got closed. Server will not be restarted.
[Error - 3:33:32 PM] Request textDocument/signatureHelp failed.
Error: Connection got disposed.
	at Object.dispose (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/main.js:904:25)
	at Object.dispose (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-languageclient/lib/client.js:74:35)
	at LanguageClient.handleConnectionClosed (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-languageclient/lib/client.js:2309:42)
	at LanguageClient.handleConnectionClosed (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-languageclient/lib/main.js:155:15)
	at closeHandler (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-languageclient/lib/client.js:2296:18)
	at CallbackList.invoke (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/events.js:62:39)
	at Emitter.fire (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/events.js:121:36)
	at closeHandler (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/main.js:240:26)
	at CallbackList.invoke (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/events.js:62:39)
	at Emitter.fire (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/events.js:121:36)
	at StreamMessageReader.fireClose (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/messageReader.js:111:27)
	at Socket.<anonymous> (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/messageReader.js:151:46)
	at Socket.emit (events.js:208:15)
	at Pipe.<anonymous> (net.js:588:12)
[Error - 3:33:32 PM] Request textDocument/foldingRange failed.
Error: Connection got disposed.
	at Object.dispose (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/main.js:904:25)
	at Object.dispose (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-languageclient/lib/client.js:74:35)
	at LanguageClient.handleConnectionClosed (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-languageclient/lib/client.js:2309:42)
	at LanguageClient.handleConnectionClosed (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-languageclient/lib/main.js:155:15)
	at closeHandler (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-languageclient/lib/client.js:2296:18)
	at CallbackList.invoke (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/events.js:62:39)
	at Emitter.fire (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/events.js:121:36)
	at closeHandler (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/main.js:240:26)
	at CallbackList.invoke (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/events.js:62:39)
	at Emitter.fire (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/events.js:121:36)
	at StreamMessageReader.fireClose (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/messageReader.js:111:27)
	at Socket.<anonymous> (/homepath/.vscode/extensions/golang.go-0.15.1/node_modules/vscode-jsonrpc/lib/messageReader.js:151:46)
	at Socket.emit (events.js:208:15)
	at Pipe.<anonymous> (net.js:588:12)

OPTIONAL: If you would like to share more information, you can attach your complete gopls logs.

NOTE: THESE MAY CONTAIN SENSITIVE INFORMATION ABOUT YOUR CODEBASE.
DO NOT SHARE LOGS IF YOU ARE WORKING IN A PRIVATE REPOSITORY.

<OPTIONAL: ATTACH LOGS HERE>

Answer 1 · 2020-07-15T11:49:49.000Z

@chikaku Thanks for the report! I am going to transfer this issue to the gopls issue tracker so gopls devs can follow up.

@pjweinbgo @stamblerre The stack trace is different from the crash reported in #40208

Answer 2 · 2020-07-15T17:23:14.000Z

Change https://golang.org/cl/242798 mentions this issue: internal/lsp/source: handle nil pointer in newBuiltinSignature