x/tools/gopls: crash in packageReferences (reported by telemetry)
Closed this issue · 2 comments
findleyr commented
In https://storage.googleapis.com/prod-telemetry-merged/2024-03-06.json:
crash/crash
runtime.gopanic:+69
golang.org/x/tools/gopls/internal/golang.mustLocation:=692
golang.org/x/tools/gopls/internal/golang.packageReferences:+91
golang.org/x/tools/gopls/internal/golang.references:+12
golang.org/x/tools/gopls/internal/golang.References:+1
golang.org/x/tools/gopls/internal/server.(*server).References:+18
golang.org/x/tools/gopls/internal/protocol.serverDispatch:+478
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52
golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2
golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3
runtime.goexit:+0":2,"gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/golang.expandMethodSearch:+4
golang.org/x/tools/gopls/internal/golang.ordinaryReferences:+143
golang.org/x/tools/gopls/internal/golang.references:+14
golang.org/x/tools/gopls/internal/golang.References:+1
golang.org/x/tools/gopls/internal/server.(*server).References:+18
golang.org/x/tools/gopls/internal/protocol.serverDispatch:+478
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52
golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2
golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3
Reproducible by requesting references when one of the package files lacks a name.
gopherbot commented
Change https://go.dev/cl/570676 mentions this issue: gopls/internal/golang: fix crash in package references
gopherbot commented
Change https://go.dev/cl/570597 mentions this issue: [gopls-release-branch.0.15] gopls/internal/golang: fix crash in package references