golang/groupcache

consistenthash.go doesn't have a "Remove" method

toli-belo opened this issue · 4 comments

toli-belo commented

curious how you guys use consistenthash.go without the Remove method. Isn't the whole beauty in the ability to make some keys unavail by removing them from the "ring" /hash value list?

LiuNingqian commented

Hi, Has this issue been resolved?

thrawn01 commented

I'm trying to understand the use case here, you can effectively "remove" a peer by re-creating the hash with a new set of peers.

  • 👍1
LiuNingqian commented

I'm trying to understand the use case here, you can effectively "remove" a peer by re-creating the hash with a new set of peers.

I also thought about the use case, but what I'm worried about is that if re-creating will change the old mapping peer.

thrawn01 commented

It can change the mapping peer, but removing a peer will also change the mapping peer.