golangci/golangci-lint

github.com/tdakkota/asciicheck no longer exists, causing installation to fail

Closed this issue · 6 comments

roganartu commented

Welcome

  • Yes, I'm using a binary release within 2 latest releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've read the typecheck section of the FAQ.
  • Yes, I've tried with the standalone linter if available (e.g., gocritic, go vet, etc.).
  • I agree to follow this project's Code of Conduct

How did you install golangci-lint?

I don't know

Description of the problem

It seems that github.com/tdakkota/asciicheck was pulled recently, as it now returns a 404. Attempting to install golangci-lint with fresh caches returns a github auth prompt and then fails.

Version of golangci-lint

https://github.com/golangci/golangci-lint/blob/c8f5c9f043308bba5ce5583b19bb35e3269b6c99/go.mod#L115C1-L115C39 is the latest master commit which references this dep.

It seems like the user deleted their github account entirely as github.com/tdakkota also 404s.

Configuration

N/A

Go environment

N/A

Verbose output of running

N/A

A minimal reproducible example or link to a public repository

N/A

Validation

  • Yes, I've included all information above (version, config, etc.).

Supporter

boring-cyborg commented

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

ldez commented

Thank you for the report, the go proxy will once again save the world 😉

I will manage the problem.

  • ❤️2
ldez commented

Just a note: using go install is not recommended https://golangci-lint.run/docs/welcome/install/#install-from-sources

We recommend using our official binaries (from package managers or our releases).

I also recommend using at least the official Go proxy instead of direct.

nwcs-sh commented 
git clone https://github.com/golangci/golangci-lint
Cloning into 'golangci-lint'...

cd golangci-lint/

stat vendor
stat: cannot statx 'vendor': No such file or directory

I think go mod vendor was invented for this but idk

ldez commented
  1. You should not build golangci-lint from source
  2. Go proxies are here to handle the situation: they don't need the GitHub repo to serve the module.
  3. You don't need to vendor dependencies.