goldfinch-eng/mono

Multiple deployment functions in `baseDeploy` do not use `DeployEffects` for upgrading config values

Opened this issue · 0 comments

Uncovered by #18

Many functions called by baseDeploy attempt to update config variables directly instead of using DeployEffects to create a multisend to be executed by the protocol owner

Examples

Incorrect example
Here, the deploy script will immediately attempt to update the config variable with using the deployer account which doesn't have permission.

Correct example
Instead, updating the config variable should be added to DeployEffects for the protocol owner to execute