goldmansachs/obevo

Rollback detection should work fine for multi-schema use case if one schema is a no-op and the other is rollback

shantstepanian opened this issue · 0 comments

The Rollback detection logic (see DefaultRollbackDetector class) has a sanity check to verify that all schemas in a deployment have the same rollback behavior. i.e. if schemas are managed in the same way, then we shouldn't encounter a case where one schema is marked as rollback and the other isn't

However, we neglected the use case where one schema is marked as rollback and the other is not (e.g. if no changes occurred on that schema)

We should fix DefaultRollbackDetector to handle this logic, along with its unit test. Also worth trying this scenario out on RollbackScenarioTest to try out the example