golemfactory/ray-on-golem

Implement `LocalHeadCommandRunner.run()`

johny-b opened this issue · 1 comments

GOAL

  1. We have a LocalHeadCommandRunner class with method run
  2. This method has the same interface as CommandRunnerInterface.run() (https://github.com/ray-project/ray/blob/master/python/ray/autoscaler/command_runner.py)
  3. All run arguments are supported in one of the ways:
  1. We have a reasonable set of tests

HOW TO START

  1. Branch: https://github.com/golemfactory/golem-ray/tree/local-command-runner
  2. Install ray and pytest
  3. python -m pytest. Two tests fail here - this is where we start.

HOW TO PROGRESS

TDD makes sense here. So:

while not_ready:
     find_single_missing_thing
     add_failing_tests_for_this_thing
     implement_this_missing_thing
     (optional) refactor

cleaning issues (issue no longer needed)