Question: why do you save speaker color in json ?
PaulLerner opened this issue · 2 comments
Hi,
I don't understand why do you save speaker color in json but you don't load it.
Would you like to implement the loading later ?
Hey Paul,
The loading does work (I've just checked).
Just to make sure we are talking on the same thing, here is what I tried:
Load demo>change one of the colors of the speaker>save>load the demo audio with the downloaded file> see that the color is similar to the saved color.
Note that the colors are handled outside the regions' plugin and are being initialized here.
A region gets its color here
The colors are saved under each of the 'speaker' entries in the json file and so they are being loaded from it.
The appropriate thing to do is to put it in some kind of metadata object, parallel to the 'monologues' entry, so we won't have so many duplicates.
It will be great if you will make this separation.
Please consider two issues:
- backwards compatibility (unless you think it is unnecessary and then I will consider it with my team)
- synchronizing colors between the same speaker in different files.
Hi Golan,
Thank you for your answer, sorry about that, I'm not sure why I thought that color loading was not efficient.
Thanks for the info !