Goodhosts don't remove duplicates

Question

Goodhosts don't remove duplicates

Mte90 opened this issue 4 years ago · 10 comments

We are facing some issues with the vagrant plugin that when we add new hosts, they are added creating things like:

192.168.50.4 vvv vvv.test boilerplate.test woocommerce.test glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test boilerplate.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test tideways.vvv.test xhgui.vvv.test vvv vvv.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test src.wordpress-develop.test build.wordpress-develop.test tideways.vvv.test xhgui.vvv.test vvv vvv.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test src.wordpress-develop.test build.wordpress-develop.test tideways.vvv.test xhgui.vvv.test vvv vvv.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test src.wordpress-develop.test build.wordpress-develop.test tideways.vvv.test xhgui.vvv.test vvv vvv.test woocommerce.test 503702305c22.ngrok.io auto.test glossary.test src.wordpress-develop.test build.wordpress-develop.test tideways.vvv.test xhgui.vvv.test

Answer 1 · 2020-09-05T20:44:58.000Z

hi @Mte90 ran some scenarios in my head while walking through code and im not sure how you ended up getting this result. if you look here: https://github.com/goodhosts/hostsfile/blob/master/hosts.go#L117 it skips dupes in the hostsfile library and here: https://github.com/goodhosts/cli/blob/master/cmd/add.go#L37-L43 in the cli it pulls dupes from the args passed.

even the remove call should take out dupes... any ideas how this could have happened? I'm currently at a loss.

Answer 2 · 2020-09-07T10:23:46.000Z

Hi @luthermonson we saw various users of the vagrant plugin with the issue.
The plugin run add on boot and remove on halt but can happen that you turn of the host machine without turning off the virtual machine so the remove command is not executed.

The fact that identify the right ip address and enqueue them is good but is not detecting in the line that domain already exists so it is appended anyway. Maybe the issue is in the domain detection in a long line?

I think that you can do some tests with that line that I shared to you but I am here for debugging also to compile the tool if needed.

Answer 3 · 2020-09-07T20:27:44.000Z

i added a clean command and ran it across your line and it improves things, perhaps we can run this before every flush in add/remove. Give it a try: https://github.com/goodhosts/cli/releases/tag/v1.0.4

Answer 4 · 2020-09-07T20:32:37.000Z

PS C:\Users\luthe\goodhosts\hostsfile> goodhosts -f ./hosts clean
PS C:\Users\luthe\goodhosts\hostsfile> type hosts
192.168.50.4 503702305c22.ngrok.io auto.test boilerplate.test build.wordpress-develop.test glossary.test src.wordpress-develop.test tideways.vvv.test vvv vvv.test woocommerce.test xhgui.vvv.test

I just can't seem to get the add to not strip out dupes.

PS C:\Users\luthe\goodhosts\hostsfile> goodhosts -f ./hosts add 192.168.50.4 503702305c22.ngrok.io auto.test boilerplate.test build.wordpress-develop.test glossary.test src.wordpress-develop.test tideways.vvv.test vvv vvv.test woocommerce.test xhgui.vvv.test
hosts entry added: 192.168.50.4 vvv.test woocommerce.test auto.test build.wordpress-develop.test vvv src.wordpress-develop.test tideways.vvv.test xhgui.vvv.test 503702305c22.ngrok.io boilerplate.test glossary.test
PS C:\Users\luthe\goodhosts\hostsfile> type hosts
192.168.50.4 503702305c22.ngrok.io auto.test boilerplate.test build.wordpress-develop.test glossary.test src.wordpress-develop.test tideways.vvv.test vvv vvv.test woocommerce.test xhgui.vvv.test

Answer 5 · 2020-09-08T10:36:35.000Z

Seems that clean that line rightly, this command can be executed on adding/removing?

Answer 6 · 2020-09-24T12:10:59.000Z

any updates?

Answer 7 · 2020-10-15T09:19:46.000Z

Sorry for delay, v1.0.5 now has all this.

Answer 8 · 2020-10-15T09:24:31.000Z

Hi @luthermonson, it is not clear to me a thing.
It is possible to do the clean on adding or remove? I am trying just to optimize the thing and avoid executing 2 commands.

Answer 9 · 2020-10-15T09:34:17.000Z

yes, there is a --clean or -c you can use on add/remove now

Answer 10 · 2020-10-15T09:43:47.000Z

Ok so I can combine them in the same command.
Thanks