goodtune/vitriolic

Start testing against Django 1.11.x series

Closed this issue · 2 comments

There is an impending LTS release coming. We know it introduces some new features which we won't have implemented against, however I'm more interested in knowing that we aren't using any deprecated features.

Only as good as our test suite is, which is a separate matter.

First issue encountered - an ImportError due to removal of undocumented classes.

Since these were removed lets look at home much the ones we depended upon changed between 1.8 (LTS) and 1.10, and copy it into the project as a compatibility shim.

We only have one place to fix:

$ ack '(SubWidget|RendererMixin|ChoiceFieldRenderer|RadioFieldRenderer|CheckboxFieldRenderer|ChoiceInput|RadioChoiceInput|CheckboxChoiceInput)' -l
touchtechnology/common/forms.py

We use the following deprecated classes:

$ ack '(SubWidget|RendererMixin|ChoiceFieldRenderer|RadioFieldRenderer|CheckboxFieldRenderer|ChoiceInput|RadioChoiceInput|CheckboxChoiceInput)' -oh | sort -u
CheckboxFieldRenderer
ChoiceFieldRenderer
RadioChoiceInput
RadioFieldRenderer