google/CFU-Playground

"make env" is broken

tcal-x opened this issue · 5 comments

tcal-x commented

After running ./scripts/setup/, then make env, I see:

Preparing transaction: done
Executing transaction: done
/media/tim/GIT/clean/CFU-Playground/env/downloads/Miniconda3-latest-Linux-x86_64.sh: 438: [[: not found

That line is

    if [[ "${env_name}" == "*" ]]; then

I'm seeing this both locally with Ubuntu 20.04 and also in Github Actions (also 20.04?) -- see the failing tests in #751.

tcal-x commented

Not sure if this is expected?

tim@tim-ubuntu:/media/tim/GIT/clean/CFU-Playground$ ls env/conda/envs/
total 12
4 '*'/  4  ./  4  ../
mithro commented

It looks like the Miniconda3-latest-Linux-x86_64.sh installer has just started using "bashisms" in their shell script?

The instructions at https://docs.conda.io/projects/conda/en/latest/user-guide/install/linux.html do say bash Miniconda3-latest-Linux-x86_64.sh

haaslukas commented

just started with a fresh ubuntu installation and git cloned the current repo. still getting the error
/CFU-Playground/env/downloads/Miniconda3-latest-Linux-x86_64.sh: 438: [[: not found

shouldn't the bash fix be merged already? if not, where is Miniconda3-latest-Linux-x86_64.sh being called in order to add the bash command manually?

proppy commented

@haaslukas looks like the submodule in https://github.com/SymbiFlow/make-env/tree/59adb0f248cc4a5d764b6b06224bf6adea7fa36e would need to be updated to point to a rev that includes mithro/make-env#31

as a workaround you should be able to update the submodule manually with:

git submodule update --remote